| lissyx | bandali, I'd say that if it builds and passes the tests, it should be good? | 07:48 |
|---|---|---|
| bandali | lissyx, sure, it does build indeed and passes my usual preliminary tests. i'll go ahead and cherry-pick to beta this morning then. thanks :) | 08:22 |
| === JanC is now known as Guest6731 | ||
| === JanC_ is now known as JanC | ||
| lissyx | bandali, I mean the tests present in the patch | 08:35 |
| bandali | lissyx, aha. do you know where/when they're run? are any of them run automatically at build time? | 08:50 |
| lissyx | bandali, it's ran on our CI for sure. | 08:50 |
| lissyx | on github actions i dont think you run anything | 08:50 |
| bandali | indeed, we only have a very simple https://github.com/canonical/firefox-snap/blob/stable/.github/scripts/firefox-basic-tests.py | 08:50 |
| lissyx | I am not sure how much we can expect to be runnable from a Firefox Snap build | 08:51 |
| lissyx | but you can always build m-c with your patch and run the tests locally | 08:51 |
| bandali | right. out of curiosity, are there any docs on how to run these outside of mozilla CI? | 08:51 |
| bandali | ah, maybe https://firefox-source-docs.mozilla.org/remote/Testing.html | 08:51 |
| lissyx | easier | 08:52 |
| lissyx | follow the build instructions | 08:52 |
| bandali | will do, thanks :) | 08:52 |
| lissyx | https://firefox-source-docs.mozilla.org/setup/linux_build.html | 08:52 |
| lissyx | bandali, if you changed the patch, you should also update https://bugzilla.mozilla.org/show_bug.cgi?id=1661935 | 08:53 |
| -ubottu:#ubuntu-desktop- Mozilla bug 1661935 in Core "Support NativeMessaging in Snap" [N/a, Assigned] | 08:53 | |
| lissyx | https://phabricator.services.mozilla.com/D140803 | 08:53 |
| lissyx | from looking there, it seems there's toolkit/components/extensions/test/xpcshell/native_messaging.ini | 08:54 |
| lissyx | so once you have a build, ./mach test toolkit/components/extensions/test/xpcshell/test_ext_native_messaging_portal.js | 08:54 |
| bandali | thanks a bunch | 08:55 |
| lissyx | bandali, on https://phabricator.services.mozilla.com/D140803 you need to scroll down and on the "Add Action" field select "Comandeer Revision" then Save | 08:57 |
| lissyx | it will make you owner of the patch | 08:57 |
| lissyx | to submit it, you'll have to use "moz-phab submit" | 08:57 |
| bandali | ack, will do | 08:59 |
| lissyx | bandali, isn't it early for you? | 09:03 |
| lissyx | (I'm updating the meeting doc) | 09:03 |
| laney | I find "crypsetup: dm_crypt-0: set up successfully" to be quite an ugly message to be displayed on the boot splash, wonder how hard it would be to get rid of it | 09:28 |
| duflu | laney, looks like it's going to stderr during initrd according to the cryptsetup source | 09:45 |
| duflu | So maybe blame cryptsetup? | 09:46 |
| duflu | Equally annoying: bug 1970069 | 09:51 |
| -ubottu:#ubuntu-desktop- Bug 1970069 in plymouth (Ubuntu) "Annoying boot messages interfering with splash screen" [Undecided, Confirmed] https://launchpad.net/bugs/1970069 | 09:51 | |
| bandali | lissyx, it is indeed :) i didn't manage to get any sleep, so i thought i'd at least put in my work hours | 10:05 |
| lissyx | seb128, bandali, a bit of a rush here, I've updated the meetings notes already and I dont think there's anything requiring more | 13:32 |
| seb128 | lissyx, k, wfm to skip again. Did you see bandali's ping yesterday to review his updated messaging patch (we needed to apply that in beta to fix the build)? | 13:42 |
| bandali | seb128, yeah lissyx helped me above with some tips actually :) i should have what i need. i'll cherry-pick the commit to beta after running its tests | 13:49 |
| lissyx | snapcraft depends on snapd ? | 13:54 |
| lissyx | asking because it looks like systemd+docker are not friends | 13:54 |
| ogra | snapcraft is a snap ... so yeah it uses snapd (do never ever use the snapcraft deb, it is dead and outdated) | 13:56 |
| ogra | at build time snapcraft needs to install the base snap you dfined in snapcraft.yaml ... so it needs snapd tere as well ... | 13:57 |
| ogra | *there | 13:57 |
| lissyx | ok | 13:57 |
| lissyx | maybe i should use the snapcraft docker directly then? | 13:57 |
| ogra | there are some wild hacks flying around that makes it work in docker though (like downloading and unpacking the snapcraft snap instead of installing etc) | 13:58 |
| lissyx | trying to get something working on taskcluster, but this systemd dependency makes it complicated | 13:58 |
| ogra | yeah, likely ... (i never even touch docker wih a ten foot pole, so not sure how wel it works) | 13:58 |
| lissyx | https://snapcraft.io/docs/build-on-docker | 14:01 |
| lissyx | ogra, this ^ ? | 14:02 |
| ogra | lissyx, yeah, i think so | 14:31 |
| lissyx | finger crossed | 14:44 |
| ahasenack | hi #desktop people, is there something I can tweak in lunar to have desktop icons appear on the "main" monitor? I have 3, side by side, and the middle one is the main one (where the dock is, for example, and where notifications pop up) | 14:46 |
| ahasenack | but things I save in the desktop (from a browser, for example), appear on the left monitor | 14:47 |
| ahasenack | where I don't see them, because I always have maximized windows on that monitor | 14:47 |
| ahasenack | or is this a bug? I would think the icons should default to appear on the main monitor | 14:47 |
| KGB-2 | mutter ubuntu/lunar 18d6fb5 Jeremy Bicha * pushed 37 commits (first 5 follow) * https://deb.li/3ptkd | 14:59 |
| KGB-2 | mutter ubuntu/lunar 87016de Carlos Garnacho src/core/window.c * core: Avoid placing hidden windows too early on Wayland * https://deb.li/3poSy | 14:59 |
| KGB-0 | mutter signed tags b98016c Jeremy Bicha ubuntu/44.2-0ubuntu1 * mutter Debian release 44.2-0ubuntu1 * https://deb.li/iQYqV | 14:59 |
| KGB-2 | mutter ubuntu/lunar da04e69 Dmitry V. Levin data/61-mutter.rules * udev-rules: Fix warnings reported by udevadm verify * https://deb.li/ijtn4 | 14:59 |
| KGB-2 | mutter ubuntu/lunar 414f30f Carlos Garnacho src/backends/native/meta-seat-impl.c * backends/native: Fix relative motion filtering for tablet tools * https://deb.li/xmKU | 14:59 |
| KGB-2 | mutter ubuntu/lunar 80e0ff1 Carlos Garnacho src/backends/native/ meta-input-device-native.c meta-input-settings-native.c * backends/native: Change handling of display mapping for rel tablet tools * https://deb.li/3KpaF | 14:59 |
| KGB-2 | mutter ubuntu/lunar 5d049af Carlos Garnacho src/backends/meta-input-settings.c * backends: Do not prevent mapping/keep-aspect changes on integrated tablets * https://deb.li/9oJ7 | 15:00 |
| lissyx | ogra, looks like this has an old python that is unhappy with f-string | 15:04 |
| jbicha | ahasenack: that's an upstream issue. See https://gitlab.com/rastersoft/desktop-icons-ng/-/issues/268 & https://gitlab.com/rastersoft/desktop-icons-ng/-/issues/135 | 15:07 |
| -ubottu:#ubuntu-desktop- Issue 268 in rastersoft/desktop-icons-ng "New Icons added to the second screen instead of default screen" [Opened] | 15:07 | |
| -ubottu:#ubuntu-desktop- Issue 135 in rastersoft/desktop-icons-ng "Allow to select the monitor where to put icons" [Opened] | 15:07 | |
| ahasenack | jbicha: thanks | 15:07 |
| bandali | hey lissyx are m-c test results and/or code related to them cached somewhere locally? i changed a test file but i don't think my change is being reflected in the test output/result | 15:44 |
| bandali | hm maybe i need to do another build | 15:44 |
| lissyx | it should not be required | 15:44 |
| bandali | right. didn't seem to help | 15:45 |
| bandali | lissyx, any idea about this "error"? https://paste.ubuntu.com/p/yr8rbBQjdq/ | 15:46 |
| lissyx | looks like you need to fix your patch :p | 15:46 |
| lissyx | looks like it also says what to do? | 15:46 |
| bandali | lissyx, lol right. i don't see any mention of ChromeUtils.import in test_ext_native_messaging_portal.js itself. i tried changing the one occurence on the line in the following link, but didn't seem to help | 15:47 |
| bandali | https://github.com/canonical/firefox-snap/blob/nightly/patches/native-messaging-portal.patch#L1624 | 15:47 |
| lissyx | the error explicitely states that ChromeUtils.import is wrong | 15:48 |
| lissyx | so your like should be:" let { getSubprocessImplForTest } = ChromeUtils.importESModule(" | 15:48 |
| bandali | i understand. what i'm saying is that changing the one occurence of ChromeUtils.import to ChromeUtils.importESModule in toolkit/modules/subprocess/test/xpcshell/test_subprocess.js doesn't seem to help | 15:50 |
| lissyx | force a rebuild then | 15:52 |
| lissyx | maybe this test is doing weird things | 15:52 |
| bandali | ok | 15:52 |
| lissyx | bandali, is it helping? | 16:06 |
| bandali | lissyx, sadly no. i'm nuking my m-c clone, sccache, and .mozbuild and trying again, basically from *scratch* | 21:05 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!