| === pieq_ is now known as pieq | ||
| lissyx | seb128, do i have a way to copy local source into the snapcraft build? | 08:01 |
|---|---|---|
| lissyx | seb128, to replace the "hg clone" step | 08:01 |
| seb128 | lissyx, you put whatever commands you want in the pull step, so yes as long as what you want to copy is available in the snapcraft environment | 08:28 |
| lissyx | "is available in the snapcraft environment" is probably what I'm unable to understand the requirements for :) | 08:28 |
| lissyx | the tl;dr is that i'd like to avoid "hg pull" since we have a local checkout of the sources un the docker | 08:29 |
| seb128 | lissyx, I'm not a snapcraft expert but I would expect that if you use destructive-mode you should be able to copy anything available on the machine | 08:33 |
| seb128 | but otherwise just include your local checkout in the srcdir that includes the snapcraft.yaml and use a relative reference? | 08:33 |
| lissyx | "local checkout in the srcdir" ? | 08:35 |
| lissyx | we have a hg clone in /builds/worker/checkouts/gecko/ | 08:35 |
| lissyx | so I'd git clone firefox-snap into /builds/worker/checkouts/ ? | 08:36 |
| lissyx | this way relative to snapcraft.yaml it's gecko/ ? | 08:36 |
| seb128 | I would expect so yes | 08:45 |
| seb128 | well you need to clone the content of firefox-snap directly into checkouts/ and not as checkouts/firefox-snap | 08:46 |
| seb128 | or otherwise your job could be; git clone ...; ln -s (if that works, otherwise cp -r); snapcraft | 08:47 |
| seb128 | like clone firefox-snap and make the content available under firefox-snap/ by ln or cp before starting snapcraft | 08:47 |
| lissyx | seb128, a symlink would be enough? | 10:29 |
| seb128 | lissyx, I don't know, I haven't tried but I would start by doing that see how it works | 10:37 |
| lissyx | perfect, let's hope I got this right this time | 10:50 |
| lissyx | seb128, the fix for ffmpeg should make it soon | 14:00 |
| lissyx | wtf https://github.com/canonical/firefox-snap/pull/13/files | 14:04 |
| -ubottu:#ubuntu-desktop- Pull 13 in canonical/firefox-snap "Bug 1729750 - Support speech-dispatcher in Snap (core22)" [Open] | 14:04 | |
| lissyx | seb128, and finally the main reason I was pushing for this, https://treeherder.mozilla.org/jobs?repo=try&revision=cf33cfb76116d82e7c29f8a3aff58c80c555aa00 | 14:11 |
| lissyx | seb128, being able to have a try run with your packaging | 14:11 |
| seb128 | thanks | 14:11 |
| seb128 | lissyx, why wtf for that speech dispatcher mr? | 14:12 |
| lissyx | seb128, the patch was ... in a weird state | 14:12 |
| lissyx | i'm wondering if there has not been a force-push done to core22 | 14:13 |
| lissyx | because my local checkout was showing the right changes | 14:13 |
| lissyx | anyway I repushed it so we are fine | 14:13 |
| seb128 | ack | 14:16 |
| lissyx | seb128, finally green: https://treeherder.mozilla.org/jobs?repo=try&revision=cf33cfb76116d82e7c29f8a3aff58c80c555aa00&selectedTaskRun=CSsXZ5muTAW-Bkv3x_I6pQ.0 | 14:41 |
| lissyx | seb128, this is using the try tree and sourcing the pre-existing checkout made (efficiently) by our infra | 14:41 |
| lissyx | seb128, the tl;dr is that to test a change, one can just push to try and collect the (opt or debug) snap directly | 14:41 |
| seb128 | great | 14:46 |
| bandali | hey lissyx, seb128, i sadly haven't been able to get a passing armhf build with debug symbols. arm64 seems to be fine though | 16:54 |
| bandali | i think after some more experimenting i'll push a commit to enable it for arm64 | 16:55 |
| bandali | (and just for reference i think the armhf failures might be due to shortage of memory, per a comment in snapcraft.yaml) | 16:55 |
| === sarnold_ is now known as sarnold | ||
| lissyx | bandali, apply the patch to reduce rust debuginfo? | 19:59 |
| bandali | lissyx, already tried but still failed: | 23:50 |
| bandali | https://git.launchpad.net/~bandali/+git/firefox-snap/commit/?h=core22-preview&id=e9bf2bdbb8d044917c0efcc3ca8828078cd0f24d | 23:50 |
| -ubottu:#ubuntu-desktop- Commit e9bf2bd in ~bandali/+git/firefox-snap "Apply mozilla-reduce-rust-debuginfo.patch on armhf as well core22-preview" | 23:50 | |
| bandali | without it, it would fail when building 'style': https://launchpadlibrarian.net/673429549/buildlog_snap_ubuntu_jammy_armhf_firefox-snap-core22-preview_BUILDING.txt.gz | 23:51 |
| bandali | with it, it progressed further, but still failed, when building 'gkrust': https://launchpadlibrarian.net/673615665/buildlog_snap_ubuntu_jammy_armhf_firefox-snap-core22-preview_BUILDING.txt.gz | 23:51 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!