| blackboxsw | falcojr: holmanb aciba I just enabled "rebase and merge" option on the cloud-init github repository UI with which I merged https://github.com/canonical/cloud-init/pull/4414. It felt better than cut-n-paste of suggested squash commit message for a single commit PR. Also, per cloud-init summit feedback, we probably should discuss supporting Merge commits for a PR for those how architect their individual commits. We may need a | 17:46 |
|---|---|---|
| blackboxsw | little work on documentation tooling to ignore merge commit messages, but we should be able to get there will little extra effort. | 17:46 |
| -ubottu:#cloud-init- Pull 4414 in canonical/cloud-init "Release 23.3.1" [Merged] | 17:46 | |
| aciba | gotcha black_boxsw | 17:56 |
| holmanb | blackboxsw: \o/ thanks for doing that | 20:16 |
| holmanb | noahm: fyi ^^ | 20:16 |
| falcojr | by default doesn't squash do the same thing for a single commit? It'll automatically use the commit message from the single commit in the text box | 20:19 |
| blackboxsw | yes, plus appending the (PR #) to the commit summary, which I almost always try to manually remove | 21:00 |
| falcojr | we want that PR # | 21:37 |
| holmanb | yeah the PR # is super helpful | 22:22 |
| * meena is almost done documenting the most important virtio functions for FreeBSD… | 23:19 | |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!