| cpaelzer | @pilot in | 06:08 |
|---|---|---|
| === ChanServ changed the topic of #ubuntu-devel to: Archive: open | Devel of Ubuntu (not support) | Build failures: http://qa.ubuntuwire.com/ftbfs/ | #ubuntu for support and discussion of Focal-Mantic | Patch Pilots: cpaelzer | ||
| artur | Hello, may I request a sponsor to review this ticket? https://bugs.launchpad.net/ubuntu/+source/alsa-ucm-conf/+bug/2042902 | 06:44 |
| -ubottu:#ubuntu-devel- Launchpad bug 2042902 in OEM Priority Project "ucm2: soundwire: add rt713 SDCA device" [Critical, In Progress] | 06:44 | |
| cpaelzer | Hi artur, give me a few minutes then I'll have a look | 06:50 |
| cpaelzer | artur: ok I see you have adressed the former issues raised by paride and athos | 07:12 |
| cpaelzer | artur: Just a check - are you around for questions if I find more that needs to be sorted out, or would you expect me to just elave whatever the final state is in the bug on launchpad? | 07:13 |
| mkukri | im looking for review on this: https://code.launchpad.net/~mkukri/ubuntu/+source/zlib/+git/zlib/+merge/456176 | 07:17 |
| mkukri | hmm can someone explain why libarchive 3.7.2-1ubuntu2 is marked as deleted, and now the known broken build libarchive 3.7.2-1ubuntu1 is marked published instead? | 08:58 |
| cpaelzer | I'm almost done with the former sponsoring case, will have a look mkukri | 08:59 |
| mkukri | thanks | 09:00 |
| cpaelzer | mkukri: it is right now moving from -proposed to -release as it completed the migration | 09:00 |
| cpaelzer | mkukri: look at https://launchpad.net/ubuntu/+source/libarchive/+publishinghistory | 09:00 |
| cpaelzer | you'll see the pattern now and in the past | 09:00 |
| cpaelzer | things get to proposed, then migration checks happen and eventually get published to -release | 09:01 |
| cpaelzer | currently the one in -proposed has been deleted and the one in -release is there but waits for a completion of the publisher to be "fully there" | 09:01 |
| cpaelzer | and if you flip open the little triangle at the beginning you'll also see that it was automation that has done that | 09:02 |
| mkukri | ah okay, sorry for bothering, i guess i hit the window where i only saw the deleted package from proposed but not the released one yet | 09:02 |
| cpaelzer | which is usually good, the cases archive admins have to step in are usually the weird and more complex ones | 09:02 |
| cpaelzer | np, I didn't consider it as bothering | 09:02 |
| cpaelzer | hey mkukri I do not have enough time left for the full depth of zlib | 09:23 |
| cpaelzer | but I can look for a few things I might see quickly | 09:24 |
| mkukri | no problem | 09:24 |
| cpaelzer | the first that I spotted is that nothing of 1:1.3.dfsg-2ubuntu1 was ever uploaded | 09:24 |
| cpaelzer | that is fine | 09:24 |
| cpaelzer | but then it should not be in the changelog | 09:24 |
| cpaelzer | so I'd expect | 09:24 |
| cpaelzer | 1:1.2.13.dfsg-1ubuntu5 (the last we had) ... 1:1.2.13.dfsg-2 ... (many debian versions) ... 1:1.3.dfsg-3 and then your 1:1.3.dfsg-3ubuntu1 | 09:25 |
| cpaelzer | and then all the comments about replaced/dropped probbaly need to move up to 1:1.3.dfsg-3ubuntu1 | 09:25 |
| cpaelzer | at least https://launchpad.net/ubuntu/+source/zlib/+publishinghistory tells me that 1:1.3.dfsg-2ubuntu1 never happened, that is what my statements are based on | 09:25 |
| mkukri | yeah so i originally merged 1:1.3.dfsg-2ubuntu1, but debian uploaded a new one today | 09:28 |
| cpaelzer | yep, I understand | 09:28 |
| mkukri | ill get it out of the changelog i suppose | 09:28 |
| cpaelzer | and you rebased | 09:28 |
| cpaelzer | that part is fine | 09:28 |
| cpaelzer | just make it all part of the one true new ubuntu changelog stanza | 09:28 |
| cpaelzer | The next is just trying to avoid potential confusion, I see these | 09:28 |
| cpaelzer | * Replaced the following patches with rebased versions: | 09:28 |
| cpaelzer | - d/p/410.patch: Add support for IBM Z hardware-accelerated deflate | 09:29 |
| cpaelzer | and above | 09:29 |
| cpaelzer | - d/p/s390x: Add optimized crc32 and hardware deflate | 09:29 |
| cpaelzer | but where is 410 gone | 09:29 |
| cpaelzer | I found it | 09:29 |
| cpaelzer | This is style only - so it is up to you, but I'd suggest something like | 09:29 |
| cpaelzer | - d/p/410.patch -> d/p/s390x/add-accel-deflate.patch : renamed and rebased | 09:30 |
| mkukri | my isue was that there is not a 1-1 correspondance between the old and new patches. because some old ones are bugfixes that got included in the new patches. but now my patches are also based on one upstream git commit instead of entire pull requests in one | 09:30 |
| cpaelzer | hmm, let me think how I'd read that case the easierst way then | 09:31 |
| cpaelzer | I like that you just made per arch subdirs now | 09:31 |
| cpaelzer | So as a rule of thumb under "Remaining changes" should only be lines that ever existed before | 09:32 |
| cpaelzer | and the good new "d/p/s390x: Add optimized crc32 and hardware deflate" has not be seen before | 09:33 |
| mkukri | so 410.patch and s390x-vectorize-crc32.patch, and d/p/1390.patch, and d/p/lp-2018293-fix-crash-in-deflateBound-if-called-before-deflateInt.patch and are equivalent-ish to the s390x subdir | 09:33 |
| mkukri | and d/p/478.patch is roughly the same as the power subdir | 09:33 |
| mkukri | im working on fixing the changelog | 09:33 |
| cpaelzer | yeah | 09:35 |
| cpaelzer | I'm trying to come up with a suggestions | 09:35 |
| cpaelzer | also d/p/power sounds like a file, but is a dir | 09:35 |
| mkukri | i have updated it a bit | 09:37 |
| mkukri | but do you have a suggestion for the dirs? | 09:37 |
| cpaelzer | yes | 09:37 |
| mkukri | maybe d/p/power/*.patch: .... | 09:37 |
| cpaelzer | on it ... | 09:37 |
| LocutusOfBorg | lvoytek, hello you there? can you please merge lua5.4 from Debian and forward there the Ubuntu delta? to me looks all upstreamable in Debian, I can sponsor if needed | 09:37 |
| cpaelzer | almost what I had | 09:37 |
| cpaelzer | mkukri: https://paste.ubuntu.com/p/kP53vGx274/ | 09:38 |
| cpaelzer | again it is style, no rule | 09:38 |
| cpaelzer | just trying to suggest to make it more clear what really happened | 09:38 |
| cpaelzer | feel free to stick to your own words if you do not like it | 09:38 |
| cpaelzer | and while we are on patches that you have properly split (thanks) to one per commit. How about proper https://dep-team.pages.debian.net/deps/dep3/ ? | 09:39 |
| cpaelzer | I could see a Bug: 1742941 / Bug: 1932010 ... 1998470 to be helpful tags | 09:40 |
| -ubottu:#ubuntu-devel- Bug 1742941 in zlib (Ubuntu) "zlib: improve crc32 performance on P8" [Low, Fix Released] https://launchpad.net/bugs/1742941 | 09:40 | |
| -ubottu:#ubuntu-devel- Bug 1932010 in zlib (Ubuntu) "[21.10 FEAT] zlib CRC32 optimization for s390x" [High, Fix Released] https://launchpad.net/bugs/1932010 | 09:40 | |
| cpaelzer | and even more, now that they are well split - Origin: upstream, <url> | 09:41 |
| cpaelzer | I love that to ensure people can easily follow up on how things might have changed since then and to compare if it really is 100% the same as upstream | 09:41 |
| cpaelzer | next comment would be that you have some changelog lines that are too wide | 09:41 |
| cpaelzer | please break them | 09:42 |
| cpaelzer | actually lintian should yell at you | 09:42 |
| mkukri | some of that is already there, ive cherry-picked the patches from git, and used gbp to export them | 09:42 |
| mkukri | i can add the origin url tho | 09:42 |
| cpaelzer | yep, the URL helps as the hash at the top might have been changed by you doing it that way | 09:42 |
| cpaelzer | as I said, I sadly do not have the time to go deeper | 09:45 |
| cpaelzer | but I hope that helps that the next reviewer does not stumble over these more superficial things | 09:46 |
| mkukri | pushed an updated version with the urls, thank you for the comments | 09:55 |
| mkukri | also, i'd like someone to sponsor this: https://code.launchpad.net/~mkukri/grub/+git/grub/+merge/455991 | 09:57 |
| mkukri | it only affects grub-install, so grub2:src upload is enough and none of the fancy UEFI signing or anything is needed | 09:57 |
| mkukri | (im also working on upstreaming that patch, but might as well fix ubuntu now) | 10:01 |
| cpaelzer | artur: completed your case, uploaded to noble | 10:05 |
| cpaelzer | artur: it needed much more, I hope the updates on the bug help you fur future uploads | 10:05 |
| cpaelzer | artur: please follow up with testing, updating the debdiffs for SRU uploads and then ask again for sponsoring | 10:06 |
| cpaelzer | Sorry mkukri my pilot shift is over (started early, need to end early) now and I have other things to attent, but you should have plenty of folks of your team around to have a look right? | 10:07 |
| cpaelzer | @pilot out | 10:07 |
| === ChanServ changed the topic of #ubuntu-devel to: Archive: open | Devel of Ubuntu (not support) | Build failures: http://qa.ubuntuwire.com/ftbfs/ | #ubuntu for support and discussion of Focal-Mantic | Patch Pilots: N/A | ||
| mkukri | yeah no worries. im just leaving the links here in case, but yeah im also trying to get foundations peeps to look at both zlib and this | 10:09 |
| === JanC is now known as Guest263 | ||
| === justThanks is now known as justache | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!