/srv/irclogs.ubuntu.com/2023/12/09/#cloud-init.txt

Code_Bleuminimal: so now my question is...is ds-identify even needed?01:34
holmanbCode_Bleu: it reduces boot time so why wouldn't you use it, even if cloud-init can do mostly the right thing without it?01:52
holmanbCode_Bleu: Also what we call "cloud-init" is harder to document and and debug and reason about in the general case if each distro / platform chooses chooses a different implementation of the final product.01:52
holmanbCode_Bleu: it's better to try to stick to a common design pattern unless there is a good reason to deviate - it makes the internal assumptions of the code base simpler too02:08
holmanbnothing is stopping end users from modifying their images to use it or not, but for the end user that doesn't want to build their own image, I think it is probably a better default than not using it02:11
Code_Bleuholmanb: does it reduce boot time?  minimal just stated with all of that it still taks 2.5 seconds.  Maybe I'm still missing something.02:39
holmanbCode_Bleu: you misunderstood, minimal said it takes 2.5 seconds without ds-identify to check datasources in python code02:46
minimalholmanb: right. I'll try adding ds-identify to Alpine for the same scenario and see what difference that makes03:43
minimalquickly, just running ds-identify manually on the CLI and looking at the "[up ..." lines at the start and end of /var/run/cloud-init/ds-identify.log appears to show it taking 14 seconds...03:47
minimaland that's without fixing detect_virtual to call "virt-what" on Alpine which would add some more time03:48
holmanb_minimal: hmmmmm, that is unexpected03:54
holmanb_minimal: could you file a bug with the log?03:56
holmanb_it's really fast on systemd systems, haven't tested elsewhere03:56
minimalah, it's 0.14 seconds......doh!03:57
holmanb_heh, okay much better03:57
holmanb_no need to file a bug obviously03:57
minimalmisrad the lines, only realised when it ran it via "time"03:57
holmanb_all good03:59
minimalthe only issue for me is I'd need to patch ds-identify to tweak the DI_DSLIST_DEFAULT value for some images I'm created04:01
minimali.e. if I'm not building images for VMware then I don't install py3-netifaces as only VMware needs it04:01
minimalbut then ds-identify has VMware in its DS list to check which would likely error if no py3-netifaces installed04:02
minimallikewise for Azure and py3-passlib04:02
minimalscanned through the ds-identify code and see a few other Alpine-related things I'll need to address04:20
meenaminimal: you don't need to patch that. you can give ds-identify a config file to read defaults from08:07
holmanbminimal: and actually 0.14 seems a little slower than I'd expect 10:22
holmanbBut been a while since ive measured 10:22
meenaholmanb: i just realized: refactoring dmi.py to go into distros would make the fallback to dmi so much easier19:41
meenaholmanb: I think I've addressed everything in your review20:37
holmanb+122:02
holmanbmeena: nice, will try to review Monday 22:02
holmanbminimal: Wikipedia suggests that Alpine's shell is actually based on dash (version 0.3.8-5)22:09
minimalholmanb: it is ash from Busybox22:48
minimalhttps://git.busybox.net/busybox/tree/shell/ash.c22:49
minimalthe config info does say it is derived from Debian dash (1997-2005)22:51
meenaso, Wikipedia skipped a few decades of info…23:16
meenaFreeBSD's sh is also ash, but from NetBSD.23:19

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!