| holmanb | minimal: +1, makes sense | 00:27 |
|---|---|---|
| holmanb | loser123: like meena said, the logs will tell what happened | 00:29 |
| holmanb_ | meena: review up for the /run symlink thingie | 18:37 |
| holmanb_ | meena: I assume the openbsd native reading one is ready for review also? | 18:41 |
| meena | yes | 18:42 |
| holmanb_ | meena: sounds good, will review | 18:44 |
| meena | holmanb_: responded to two questions | 18:52 |
| meena | I can't wait till FreeBSD gets that man page renderer | 18:57 |
| meena | https://man-dev.freebsd.org/test.1#L still in development | 18:57 |
| holmanb_ | Code_Bleu: ping | 19:21 |
| holmanb_ | Code_Bleu: I saw you got in an early review on #4654, are you good with the changes there? | 19:21 |
| meena | holmanb_: is ubottu down? | 19:29 |
| holmanb_ | meena: no clue | 19:34 |
| holmanb_ | I don't even know who runs ubottu, but ubottu has been pretty unresponsive lately | 19:35 |
| meena | holmanb_: anyway, don't know if i can get the style change in in time, trying to put my daughter to sleep | 19:36 |
| holmanb_ | meena: no worries on that, it doesn't need to happen | 19:36 |
| meena | re @ computer | 20:16 |
| meena | holmanb_: fixed your complaint and also the two adjecent functions using the same pattern | 20:22 |
| meena | holmanb_: tests on 3.7 failing? https://github.com/canonical/cloud-init/actions/runs/7172956839/job/19531252604?pr=4654 | 20:45 |
| meena | nope, all unittests are failing | 20:45 |
| meena | found it | 21:11 |
| holmanb_ | meena: just got done with an interview | 21:13 |
| holmanb_ | yeah forgot to mention it needs a SubpResult when mocking the test | 21:14 |
| meena | fixed unittests | 21:14 |
| holmanb_ | thanks, yeah slight burden on tests to to make the runtime code prety | 21:14 |
| holmanb_ | but it's not like (many of) our unittests are pretty anyways :P | 21:15 |
| holmanb_ | meena: nice, thanks :D | 21:15 |
| Code_Bleu | holmanb_: yes I'm good with #4654 | 21:20 |
| meena | Code_Bleu: give it your official thumbs-up! | 21:22 |
| Code_Bleu | meena: I replied to holmanb_ comment on PR. That work? | 21:25 |
| holmanb_ | Code_Bleu: fyi under [Files changed] there's a green button [Review changes] that allows you to leave a "review" (comment, review, request changes) | 21:32 |
| holmanb_ | Code_Bleu: but the comment is enough for me :) | 21:32 |
| holmanb_ | s/review,/approve,/ | 21:32 |
| holmanb_ | Code_Bleu meena: merged | 21:34 |
| holmanb_ | and thanks to both of you :) | 21:36 |
| meena | next up, fixing /run … | 21:36 |
| Code_Bleu | holmanb_: thanks for FYI. Will do that next time. | 21:51 |
| holmanb_ | Code_Bleu: sure, sounds good | 21:53 |
| holmanb_ | honestly not a requirement except for a committer to do the official review thingie for another committer to merge, but it makes the review look a tad bit nicer / more official I guess | 21:59 |
| meena | also: 🎇 Community Engagement! 🎇 | 22:52 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!