| === cznk_ is now known as cznk | ||
| blackboxsw | aciba: cloud-init SRU uploads have now be dput to both ubuntu -proposed review pockets and ppa:cloud-init-dev/proposed | 15:59 |
|---|---|---|
| blackboxsw | for Ubuntu focal, jammy, lunar and mantic | 16:00 |
| holmanb | minimal: I know you were considering adding ds-identify before the new year. Is that something you plan on working on in the near future? If not I'd like to create a github issue to capture that and save the comments you made earlier about required changes to ds-identify. | 16:52 |
| minimal | yes, I'm have been working on that over the holiday period (as well as cc_growpart stuff) | 17:07 |
| minimal | I have some local ds-identify changes that I need to test, just got sidetracked with the growpart stuff lol | 17:09 |
| aciba | thanks blackboxsw for the uploads! | 18:27 |
| blackboxsw | np aciba heading through your deb822 pr now thx | 18:27 |
| holmanb | minimal: nice, happy to help review that when ready | 21:51 |
| meena | holmanb: first you gotta review my PR that touches ds-identify | 21:53 |
| meena | the one that's already submitted | 21:53 |
| holmanb | meena: I'm looking at that one now :) | 21:53 |
| meena | nice | 21:53 |
| holmanb | everyone wants to change ds-identify lately lol | 21:54 |
| meena | would be cool if you could do `with contextlib.suppress(FileNotFoundError) and open(lease_file, "r") as fd:` just like that in one line | 21:56 |
| holmanb | meena: there's a way to chain context managers | 21:58 |
| holmanb | meena: not as a slick language feature like that, but using a builtin module | 21:58 |
| holmanb | https://docs.python.org/3/library/contextlib.html#contextlib.ExitStack | 21:59 |
| falcojr | we used it a lot in tests as a way to mock a bunch of things without having a ton of nested context manager mocks or a million mock decorators on each function. The mocker fixture takes care of that now though | 22:01 |
| meena | that is mentioned here too https://stackoverflow.com/questions/3024925/create-a-with-block-on-several-context-managers | 22:01 |
| meena | looks like a builtin feature to me: , | 22:03 |
| falcojr | would the first syntax in that accepted answer work? `with contextlib.suppress(...), open(...) as fd:` ? | 22:03 |
| meena | I wonder | 22:04 |
| meena | would recover one indentation level here, https://github.com/canonical/cloud-init/pull/4728/files | 22:05 |
| -ubottu:#cloud-init- Pull 4728 in canonical/cloud-init "Minor dhcp fixes" [Open] | 22:05 | |
| holmanb | nice suggestion, that works | 22:07 |
| holmanb | just pushed the update | 22:08 |
| meena | 🚀 | 22:09 |
| meena | I need to fix a few tests I've written then that could benefit from this | 22:10 |
| holmanb | meena: review submitted | 23:34 |
| minimal | holmanb: is the WSL datasource invisible? ;-) | 23:58 |
| holmanb | minimal: the python part of it? | 23:58 |
| holmanb | minimal: I guess they're contributing that seperately | 23:59 |
| holmanb | but we've already talked about their approach internally so I know that the datasource implementation in python is comming next | 23:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!