[00:01] <minimal> ok, so they're putting the cart before the horse lol
[00:46] <holmanb> you could say that I suppose
[00:51] <holmanb> the pr description laid out a plan saying that they'll contribute the datasource next, and I know there is some internal pressure to get it to happen so I wasn't too worried about it
[00:51] <holmanb> but I guess normally I'd ask to see the whole PR for a working datasource (though that's admittedly a lot more to review than the +76/-1 they have currently)
[00:52] <holmanb> my main concern with their current approach is that I think it's possible (though unlikely) for a false positive based on that grep in /proc/mounts
[00:59] <minimal> holmanb: my fault for not reading the PR properly, doh!
[01:00] <holmanb> all good :)
[01:01] <minimal> I'm curious how a WSL datasource is going to work
[01:02] <minimal> especially as yesterday I was talking to someone trying to get cloudbase-init working on Windows lol
[01:02] <holmanb> minimal: its going to be a little weird
[01:02] <holmanb> heh, cloudbase-init
[01:03] <holmanb> is it still maintained?
[01:03] <minimal> yeah it's been around for year, yupe had a look at it yesterday and it has recent commits
[01:03] <holmanb> huh
[01:04] <minimal> https://github.com/cloudbase/cloudbase-init/commits/master/
[02:23]  * holmanb stops writing words about the aix code
[02:24] <holmanb> minimal: oh nice, they plan to add freebsd
[02:24] <holmanb> https://cloudbase.it/cloudbase-init/
[09:15] <meena> i didn't even see https://github.com/canonical/cloud-init/pull/4713#discussion_r1441224689 
[09:15] -ubottu:#cloud-init- Pull 4713 in canonical/cloud-init "Support for AIX" [Open]
[09:16] <meena> I guess i was too focused on all the other weird things in this
[15:09] <holmanb> meena: no worries, and thanks for starting reviewing it
[15:09] <holmanb> meena: there's a lot of weirdness to chew on
[15:10] <meena> yeah, i feel like they need someone to sit down and hold their hand thru this process
[15:11] <holmanb> same
[15:11] <holmanb> That's why i wrote as much as i did in my initial review
[15:12] <holmanb> Honestly maybe i should drop the content that i wrote into the docs
[15:12] <meena> "so you want to cloud-init to a new platform?"
[15:16] <minimal> holmanb: not sure if you looked at the channel logs for the holiday period, I posted some IBM links re cloud-init, seems like the changes in that PR have been used by them for a long time, one doc talking about a REALLY old cloud-init version
[15:16] <meena> minimal: i tried hard to repress those memories
[15:17] <minimal> so they're not really porting cloud-init to a "new" platform now, they hacked AIX (and other) support into their own "fork" quite some time ago :-(
[15:18] <meena> minimal: that doesn't explain the syntax errors tho
[15:18] <meena> (which i also missed)
[15:18] <holmanb> minimal: I must have missed the docs you linked
[15:19] <holmanb> minimal: but that doesn't surprise me since the new files have a copyright 2015
[15:30] <meena> holmanb: need to go shopping & cooking now. Gimme a shout if you merge my PR so i can update the OpenBSD and FreeBSD ports.
[15:36] <holmanb> meena: will try to re-review this morning
[15:36] <holmanb> and will ping when done
[15:38] <holmanb> meena: I had one question about print_info() in the review, I don't see changes or response on that so guessing that got missed?
[15:38] <holmanb> https://github.com/canonical/cloud-init/pull/4677/files#r1441070610
[15:38] -ubottu:#cloud-init- Pull 4677 in canonical/cloud-init "fix(runpath): On *BSD, create /run is not ephemeral" [Open]
[15:38] <minimal> holmanb: https://www.ibm.com/docs/zh-tw/powervc/2.0.1?topic=aix-custom-powervc-cloud-init-modules and https://www.ibm.com/docs/zh-tw/powervc/2.0.1?topic=init-installing-configuring-cloud-aix
[15:50] <holmanb> thanks minimal
[15:51] <holmanb> last updated 2023 and the second instruction says "make sure python 2.7 is installed"
[15:51] <holmanb> oof
[17:18] <meena> holmanb: oh, you had answered that yourself.
[17:19] <holmanb> no, I wasn't answering my own question - just adding context about which ones I think should stay
[17:19] <holmanb> I still think we should drop the DI_LOG and ensure_sane_path calls
[17:19] <holmanb> unless there is some reason that I haven't realized
[17:19] <meena> I need to go over that code again. sh is just the worst 
[17:20] <meena> like, imagine having data structures, instead of global variables?
[17:20] <holmanb> meena: agreed - could you rewrite ds-identify in rust while you're fixing that? thanks!
[17:21] <minimal> please don't rewrite ds-identify any more until I finish rewriting it! ;-)
[17:22] <holmanb> I guess we can all take turns rewriting ds-identify
[17:47] <meena> I think Odd_Bloke started on actually
[17:50] <meena> there's https://github.com/OddBloke/distro-info-rs
[17:54] <meena> ah, here it is, https://github.com/OddBloke/rs-identify
[17:57] <meena> oh, and obviously I already contributed FreeBSD support, lol
[18:01] <minimal> oh dear, I thought you were joking about Rust...
[18:05] <meena> I just had another discussion in #bsdports with people complaining about having to compile rust so they can compile python-cryptography
[18:06] <meena> when the real problem is that due to the way our dependencies are structured, every time curl updates, rust needs to be recompiled, which, imo, is the real problem
[18:07] <meena> but i repeat myself
[18:08] <minimal> it's not just dependancies, from memory Rust only supports a few archs as "tier 1"...which is not great for distros support a range of archs
[18:10] <meena> fun fact: I removed dmidecode as dependency on cloud-init in FreeBSD, so that it could be made platform independent
[18:11] <meena> minimal: I think FreeBSD is a Tier 3 platform…… 
[18:12] <meena> anyway, i don't think anyone is in a hurry to reimplement ds-identify
[18:12] <meena> it'd be too much work for too little gain
[18:13] <minimal> meena: yupe, unfortunately as my Alpine-related changes to ds-identify use "virt-what" to detect which VM is used that added "dmidecode" back as an Alpine package dep :-(
[18:13] <minimal> virt-what has dmidecode dep
[18:13] <meena> boooo
[18:14] <meena> time to either fix dmidecode or virt-what
[18:15] <meena> oh, cuz you don't have systemd to tell you what virtualization you're on
[18:15] <minimal> virt-what is using dmidecode, don't have time to try and create a virt-what PR to try and use /sys instead
[18:15] <minimal> meena: yupe, precisely
[18:15] <minimal> and I've so far not found a suitable alternative to virt-what
[18:17] <minimal> meanwhile I'm fighting with growpart testcases as I added a new subp call to growpart and need to figure out mocks for those testcases :-(
[18:19] <meena> https://github.com/canonical/cloud-init/blob/main/tools/ds-identify#L455 that sysctl is so handy
[18:23] <minimal> yeah. I'll use virt-what for now but keep an eye out for any suitable alternative in the future
[18:24] <minimal> its only 48kB of shell + 172kB for dmidecode so not a large extra dep
[18:36] <meena> for this, https://github.com/systemd/systemd/blob/main/src/basic/virt.c#L249
[18:42] <minimal> that's 1064 lines of non-standalone code, whereas virt-what is shellscript where I could just replace dmidecode calls with reading files in /sys/..............or write my own virt-what alternative in shell also
[19:24] <holmanb> yeah I think that there have been a few ds-identify rust attempts in the past
[19:25] <holmanb> and I was only joking, not in a hurry to replace it
[19:26] <holmanb> meena: FreeBSD & NetBSD are Tier 2 for x86_64
[19:28] <holmanb> same for musl on x86_64 and aarch64
[19:31] <minimal> the Rust "issue" is more about other archs like armv7, ppc64le and riscv64 (and perhaps even more obscure archs that some distros support)
[19:33] <holmanb> given the linux kernel's ongoing adoption, I'm hopefully that will increase pressure for adding tier 1 support to other platforms over time
[19:34] <minimal> also, perhaps wrongly, I get the impression that the whole Rust dev infra is not really distro-friendly, i.e. "oh yeah that code doesn't work because you're using version A.B.C of dep RANDOM-DEP whereas you need to use the git master/main of RANDOM-DEP from 10 minutes ago"
[19:35] <holmanb> true - that's always been a problem with OS development though, stability requires maturity and a slower pace of change
[19:35] <minimal> and again, perhaps wrongly, I get the impression that some (much?) Rust stuff just doesn't do releases at all
[19:36] <holmanb> there's a reason cloud-init doesn't use the latest jsonschema and tries hard to limit dependencies
[19:37] <minimal> wasn't there a "so when will cloud-init be rewritten in Rust?" issue raised a month or 2 ago? lol
[19:37] <holmanb> not sure what you mean by that, crates _are_ releases aren't they?
[19:38] <meena> whoohooo it's 19:38 and kiddo is asleep and it's before 22:30, which i think is the earliest she's been asleep at for the past two weeks
[19:38] <meena> So much free time now
[19:39] <holmanb> minimal: yeah, those kind of issues are pretty narrow-sighted and also too common from rust fanatics - I left the issue open so that if we get any more I can close them as duplicates
[19:39] <holmanb> meena: think we can land the /run one today?
[19:40] <minimal> holmanb: I've never touched Rust myself so I'm probably getting the wrong impression of some stuff but from watching comments in the likes of the alpine devel channel, especially when a new Rust version comes out and it has to be bootstrapped etc
[19:41] <meena> how many thousands lines of code is cloud-init?
[19:42] <meena> and how many person-years of engineering is it? 
[19:43] <holmanb> excluding tests, the python code in cloudinit is around 67k LOC
[19:44] <holmanb> including tests somewhere around 150k
[19:44] <meena> if we set out today to rewrite it bit by bit, with all that we know, about clouds and distros, not so much about python quirks, how many years of engineering would it take to replicate that (while picking up on rust quirks?)
[19:44] <holmanb> not stripping whitespace: `find cloudinit -name '*.py' | xargs wc -l`
[19:45] <minimal> meena: perhaps look at what was the CoreOS c-i alternative in GoLang (is "ignition" the same code or another rewrite?)
[19:46] <holmanb> ignition is CoreOS-only last time I checked
[19:46] <holmanb> and runs from initramfs
[19:46] <holmanb> yeah no clue on the engineering time, and frankly not interested in a feature-for-featurer rewrite in any language
[19:47] <holmanb> improving performance by augmenting certain parts of cloud-init in a different language might be feasible
[19:49] <minimal> I've not seen any c-i alternative that comes close to c-i in terms of matching its functionality, they usually just implement a few DSes
[19:51] <meena> and only a few modules
[21:03] <meena> holmanb: here's what's happening without the DI_LOG=stderr
[21:03] <meena> tools/ds-identify: 185: 3: Bad file descriptor
[21:03] <meena> tools/ds-identify: 185: 3: Bad file descriptor
[21:47] <meena> holmanb: i removed `set_run_path`, because that, as it turns out, is not necessary
[22:40] <holmanb> how are you running it? 
[22:46] <holmanb> meena: see my latest comment
[22:53] <meena> holmanb: set_run_path needs to come after read_uname_info
[22:54] <meena> otherwise, i might have to do this:
[22:54] <meena> https://gist.github.com/igalic/1a959dbeb0f81a516e5a29a518419dfd to ensure we stay working on Linux by default…
[22:55] <holmanb> Ahhhh, I forgot that
[22:56] <holmanb> that explains why the DI_LOG issue
[22:56] <meena> it does?
[22:56] <holmanb> Because DI_LOG is set in set_run_path
[22:57] <meena> duh, that's why i have to override it
[22:57]  * meena shouldn't be doing 3 things at once 
[22:57] <holmanb> You and me both multitasking a bit too much
[22:58]  * holmanb is reviewing like 3 PRs at the same time
[22:58] <meena> I'm writing a project plan, rewatching Life on our Planet for the third time, and trying to make sense of 2000 lines of sh
[23:02] <holmanb> I might have an idea for this
[23:04] <meena> i could also just bomb out in set_run_path if DI_UNAME_KERNEL_NAME isn't set
[23:07] <holmanb> Need to drive across town jn a snowstorm first, but i think this is best fixed in the logger function
[23:07] <holmanb> Check id DI_LOG is set to "" and set to stderr if not
[23:18] <meena> holmanb: okay, done.
[23:27] <holmanb> Made it
[23:28] <holmanb> snack then ill review