| aciba | Hi, I found a hotplug-related bug https://github.com/canonical/cloud-init/issues/4886 which I think it was introduced by https://github.com/canonical/cloud-init/pull/4772 | 10:47 |
|---|---|---|
| -ubottu:#cloud-init- Issue 4886 in canonical/cloud-init "cloud-init-hotplugd.{service,socket} error: argument -s/--subsystem: invalid choice: ''net''" [Open] | 10:47 | |
| -ubottu:#cloud-init- Pull 4772 in canonical/cloud-init "Modify hook-hotplug to be POSIX shell, add OpenRC init script" [Merged] | 10:47 | |
| aciba | minimal: why is the arg qouting needed in tools/hook-hotplug ? | 10:49 |
| minimal | aciba: The quoting was in the original code, I just escaped them when I converted the code from Bash to POSIX sh | 17:42 |
| blackboxsw | aciba: thanks for the fix there. It shouldn't have been needed and all of those args are single params that don't contain spaces, so I don't think that's actually warranted there. I also want a better integration test on hotplug which looks at the state of systemctl status cloud-init-hotplug.service on systemd environments as we otherwise get non-specific errors when things fall apart. | 20:33 |
| blackboxsw | I"ll post a small diff to your PR with that integration test change once I'm sure it's working. | 20:34 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!