[15:26] <minimal> meena: the testcase test_missing_keydata is LUKS-specific and so not relevant for ZFS encryption
[16:03] <meena> minimal: yes, but i changed the code leading into that, so now it's failing and i don't know why
[16:10] <minimal> meena: yeah, been there, done that, lol. I had another go at digging into testcase failure after my own (local) growpart changes and still haven't gotten by head around things yet
[16:14] <minimal> meena: in your case I assume the problem is that your changes added a subp call for "zpool" but I dodn't see any mocking changes you've made to the testcases to deal with this
[16:38] <meena> minimal: because nothing should be hitting that line yet
[16:40] <minimal> ah ok
[17:28] <holman> Ill take a look
[19:28] <meena> holman: for now, I'm running tests on Ubuntu, BTW, haven't dared to look at them on FreeBSD in a few weeks