[18:52] <holman> minimal sounds like an easy enough logic to implement 
[18:55] <minimal> holman: yeah. I'm surprised that it didn't come up before.
[18:55] <minimal> I guess perhaps not many people use the disk_setup or mount modules
[18:59] <holman> Yeah i guess not
[18:59] <minimal> so that NVME devices are more common these days so it's the most likely type of device with the "pX" naming to be encountered
[18:59] <minimal> s/so/or/
[22:31] <holman> minimal: I made a patch to fix it... but i think that I lost it while rebasing earlier, I'll see if i can dig it out of git's bowels
[22:31] <holman> If not it was trivial
[22:32] <holman> Not sure we really need to worry about /dev/by-*
[22:32] <holman> Since partition number is a user-provided value
[22:34] <holman> The more i look at this module the more problems i see
[23:02] <meena> holman: git reflog + cherrypick?