| minimal | further feedback, the BSD tests are failing their "assert m_subp.call_args_list == []" as the BSD tests include a "ifconfig -a" subp (see test_freebsd.py for how it does a mocker.path.object for "networking_cls" to avoid this, similar for netbsd/openbsd) | 00:14 |
|---|---|---|
| blackboxsw_away | minimal thanks. I've adapted the tests to actually validate the actual distro passwd path matches the injected parametrized test path (/etc/master.passwd vs /etc/shadow) | 03:16 |
| blackboxsw_away | And per the subp mocks, I intentionally am trying to avoid side-effects of __init__ methods which shell out to invoke programs, parse output and seed dictionaries before any methods actually attempt to use that data. That 'work' should generally be done only when needed (and cached) when methods or ops actually require the parsed output. | 03:17 |
| blackboxsw_away | Moving that subp call out of NetworkingBSD.__init__ impacted those tests which mocked the side-effect which were a smell that instance initialization was doing more work than it should. | 03:17 |
| blackboxsw_away | just force pushed unittest changes which extend coverage for openbsd/netbsd/freebsd in test_create_users.py and drops unnecessary duplicated tests from test_*bsd.py::test_check_existing_password_for_user" | 03:34 |
| === Juesto is now known as Juest | ||
| === cpaelzer_ is now known as cpaelzer | ||
| === kuraudo1 is now known as kuraudo | ||
| === benj_0 is now known as benj_ | ||
| === terrorjack49 is now known as terrorjack4 | ||
| === andrewbogott_ is now known as andrewbogott | ||
| === andrewbogott is now known as Guest7691 | ||
| === blackboxsw_away is now known as blackboxsw | ||
| === Guest7691 is now known as andrewbogott | ||
| minimal | blackboxsw: I pushed some further minor changes | 15:18 |
| minimal | I've now got a conflict that I can't seem to resolve in github | 15:18 |
| === dbungert1 is now known as dbungert | ||
| blackboxsw | minimal: changes look good. let's see if we can resolve the conflict. Pulling it down now | 15:59 |
| blackboxsw | minimal: just rebased against main, resolved conflicts and force pushed to your branch. I added another single commit to drop unnneeded mocks of BSDNetworking. Running through integration tests now, I may want to extend the integration test we have to exercise pre-existing user with empty passwords on lock_passwd: false. But other than that I think thinks are looking good | 18:24 |
| holmanb | [community notice]: we have a big change coming in cloud-init, see this post for more information -> https://discourse.ubuntu.com/t/announcement-cloud-init-perfomance-optimization-single-process/ | 23:06 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!