| === pushkarnk1 is now known as pushkarnk | ||
| thibf | mee | 14:01 |
|---|---|---|
| thibf | wrong window focused | 14:02 |
| doko | Rhonda: https://packages.ubuntu.com/search?searchon=contents&keywords=sbuild-package&mode=filename&suite=plucky&arch=any Internal server error | 14:42 |
| waveform | paride, could you have a look at https://code.launchpad.net/~waveform/meta-release/+git/meta-release/+merge/477243 when you've got a mo? Should fix up the issue with the meta-release CI | 15:33 |
| paride | waveform, ack, in calls now, then I'll look | 15:34 |
| paride | waveform, your "lunar and mantic have moved to old-releases" commit is identical to https://code.launchpad.net/~hyask/meta-release/+git/meta-release/+merge/477242 | 16:16 |
| waveform | ah, I just added those as when I ran the pre-commit pipeline locally it flagged up those as failures too so I figured "may as well fix it all while I'm here!" | 16:17 |
| Skia | yay, that means the pre-commit stuff is working great! | 16:17 |
| Skia | paride: just merge waveform's MP and drop mine, it's fine ;-) | 16:18 |
| waveform | well, sort of -- it doesn't seem to want to run the pipeline on my MR... | 16:18 |
| paride | but I think that's LP fault | 16:19 |
| Skia | you mean on Launchpad? That's an LP thing, while I was only talking about the local pre-commit | 16:19 |
| waveform | ah, okay | 16:20 |
| waveform | I don't *think* the local pre-commit is necessarily working -- I just ran it manually | 16:20 |
| waveform | I certainly needed two commits to fix all issues, and it happily allowed the first commit without complaint (which only fixed the raspi JSON) | 16:20 |
| Skia | pre-commit only checks the changed files | 16:21 |
| waveform | ahh | 16:21 |
| Skia | which good, and bad | 16:21 |
| waveform | well, that's fine actually -- I'd much rather be able to make two commits for two semantically different changes | 16:21 |
| Skia | because you miss other broken stuff, but it allows your work to go through, without bothering you with other people's stuff | 16:22 |
| Skia | since you're the main maintainer of the rasp json files, you might want to have a look at the `meta_release_checker.py` script, and see about making a version for the rasp | 16:23 |
| Skia | (or see to have your assets do so :D) | 16:23 |
| waveform | there's already a test-suite for the JSON, and a separate test-suite for refresh_os_list (built into the script), and pre-commit hooks run both | 16:24 |
| Skia | amazing, all fine then | 16:24 |
| paride | waveform, do we agree that lpci seems stuck? | 16:26 |
| waveform | certainly appears that way | 16:27 |
| paride | waveform, can you try to kick it by doing a no-change `git commit --amend` and a push? | 16:35 |
| paride | *force push | 16:36 |
| waveform | sure, one sec | 16:36 |
| waveform | done | 16:37 |
| paride | looks like it's running now | 16:38 |
| === JanC is now known as Guest723 | ||
| waveform | and passed \o/ | 16:42 |
| rbasak | ogra_: thank you for the correction. Freenode "felt wrong" when I typed it, but then I thought "oh, because it's not OFTC" :) | 19:33 |
| rbasak | (in my head, Freenode is still the new thing after the whole openprojects drama :-P | 19:34 |
| === dviererbe1 is now known as dviererbe | ||
| === JanC is now known as Guest7379 | ||
| === JanC is now known as Guest3827 | ||
| cjwatson | Skia,waveform: you can also always use git commit -n to ignore pre-commit hooks if you really know better | 23:38 |
| cjwatson | Not a good _habit_ to be in, but sometimes needs must ... | 23:39 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!