/srv/irclogs.ubuntu.com/2022/06/28/#mir-server.txt

-GitHub[m]:#mir-server- **[MirServer/mir]** wmww edited [pull request #2495](https://github.com/MirServer/mir/pull/2495): Attempt to refactor geometry types without breaking MirAL ABI00:10
RAOF<Saviq> "And https://github.com/MirServer..." <- Can be dropped01:04
RAOFAh. I see CI is on fire with the snap store being unavailable.07:50
SaviqYeah it will be quite unhappy…08:05
Saviqsophie hey, not sure what's expected after ↑, but ubuntu-frame-vnc still reports 100% damage. That said, it does throttle frames down to 0 when nothing changes. I suppose that's expected when there's only a single full-screen app?11:52
sophie-w@Saviq yeah, we don't yet track damage areas of a surface, we treat a whole surface as damaged every time it gets a new frame 14:31
sophie-wBut if you had multiple displays with different apps, or split screen, damage would be useful (which I think is relevant, because you really don't want to capture two full displays worth of content twice as much as needed)14:33
sophie-wI suppose actually sending the damage to the client instead of just using it to know when to capture isn't getting us that much, but by the time everything else was wired up it was easy to implement14:35
sophie-wTracking surface-level damage would be a useful thing not only for screencopy, but also for some platforms (according to RAOF), but I don't see that as a priority14:36
alan_g[m]Tracking damage is an optimisation. We will need it for various things, but those things need to first work.14:42
sophie-wRE https://github.com/MirServer/mir/pull/2494#discussion_r908256638: I fail to see how a visible ImmediateExecutor type would be useful (aside from maybe using dynamic_cast<>ing to check if things are it, which we probably want to avoid). Since there's only one possible implementation of ImmediateExecutor, anything that would take an ImmediateExecutor could simply take nothing and hard-code in the one to use.16:11
SaviqGood night o/16:27
-GitHub[m]:#mir-server- **[MirServer/mir]** wmww opened [pull request #2496](https://github.com/MirServer/mir/pull/2496): Refactor SurfaceObserver types to be compatible with new observer system17:45
-GitHub[m]:#mir-server- 17:45
-GitHub[m]:#mir-server- > Because the modern observer system does not always send notifications on the same thread, it needs to be given types it can hold ownership of. This PR changes types used by SurfaceObserver to work. All methods still take a raw surface pointer, which is generally not used and should be removed, but that is out of scope here.17:45
-GitHub[m]:#mir-server- **[MirServer/mir]** wmww opened [pull request #2497](https://github.com/MirServer/mir/pull/2497): Use new MOCK_METHOD macro in MockSceneSession17:50
-GitHub[m]:#mir-server- **[MirServer/mir]** wmww edited [pull request #2497](https://github.com/MirServer/mir/pull/2497): Use new MOCK_METHOD macro in MockSceneSession17:50
-GitHub[m]:#mir-server- **[MirServer/mir]** wmww closed [pull request #2493](https://github.com/MirServer/mir/pull/2493): AbstractShell: refactor confinement17:51
-GitHub[m]:#mir-server- **[MirServer/mir]** wmww reopened [pull request #2493](https://github.com/MirServer/mir/pull/2493): AbstractShell: refactor confinement17:51
sophie-wgrayson-g: easy review: https://github.com/MirServer/mir/pull/249718:48
sophie-wgmock has added a new, improved syntax for mock functions since most of our mocks were written. Not only does it prevent you from having to specify the number of arguments in the macro name, it allows marking methods `override` (which prevents us accidentally failing to update/remove them when the base class changes)18:50
grayson-g[m]on it18:50
-GitHub[m]:#mir-server- **[MirServer/mir]** bors[bot] merged [pull request #2497](https://github.com/MirServer/mir/pull/2497): Use new MOCK_METHOD macro in MockSceneSession19:25
-GitHub[m]:#mir-server- **[MirServer/mir]** wmww opened [pull request #2498](https://github.com/MirServer/mir/pull/2498): Allow --add-wayland-extenions all and clean up help message... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/5332a8fadc54ce441f20b7339aaa8888288b492d)19:42
sophie-wGitHub -> Matrix bot seems needlessly verbose to me. Would it be possible to:19:45
sophie-w- Not include full issue/PR text19:45
sophie-w- Not include issue/PR edited/closed (only opened)?19:45
sophie-wI would look into that myself if I had any idea where it is hosted/configured19:45
sophie-w * GitHub -> Matrix bot seems needlessly verbose to me. Would it be possible to:19:45
sophie-w- Not include full issue/PR text19:45
sophie-w- Not include issue/PR edited/closed (only opened)?19:45
sophie-wI would look into that myself if I had any idea where it is hosted/configured19:45
-GitHub[m]:#mir-server- **[MirServer/mir]** wmww edited [pull request #2498](https://github.com/MirServer/mir/pull/2498): Allow --add-wayland-extenions all and clean up help message19:47
Saviq> <@wmww:matrix.org> GitHub -> Matrix bot seems needlessly verbose to me. Would it be possible to:... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/dba25b76e8ab92823b1755622801e79e29e13e36)19:55
Saviqsophie can you see https://github.com/MirServer/mir/settings/hooks/360169876 ?19:57
SaviqIf you can, you'll see that there's very little that's enabled, but I agree it's too verbose still19:59
sophie-w404 :(20:21
Saviq<sophie-w> "404 :(" <- How about now?20:30
sophie-whttps://github.com/MirServer/mir/settings/hooks/360169876 still 404s for me20:32
Saviqsophie-w: Should be there now. Apparently that's "sensitive or destructive"20:32
sophie-w(it's fine, I believe you've turned off what you can)20:32
sophie-wThanks, now I see it20:32

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!