| mborzecki | morning | 05:27 |
|---|---|---|
| pedronis | mborzecki: hi, I would appreciate reviews for #8907 and #8984 | 06:39 |
| mup | PR #8907: asserts: implement Database.FindSequence <validation-sets :white_check_mark:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/8907> | 06:39 |
| mup | PR #8984: asserts: integer headers: disallow prefix zeros and make parsing more uniform <validation-sets :white_check_mark:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/8984> | 06:39 |
| mborzecki | pedronis: hi, will do | 06:40 |
| pedronis | thx | 06:42 |
| pstolowski | morning | 07:03 |
| mborzecki | mvo: pedronis: sent out the tiny spec for uc20 recovery on rpi, please take a look | 07:11 |
| mborzecki | pedronis: mvo: i'll write down something similar about grub.cfg command line and share it with you guys | 07:12 |
| pedronis | mborzecki: ok, I'll see when I can look at it | 07:15 |
| pedronis | pstolowski: hi, #8907 needs a review, I also made #8984 | 07:15 |
| mup | PR #8907: asserts: implement Database.FindSequence <validation-sets :white_check_mark:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/8907> | 07:15 |
| mup | PR #8984: asserts: integer headers: disallow prefix zeros and make parsing more uniform <validation-sets :white_check_mark:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/8984> | 07:15 |
| pstolowski | pedronis: hi, will review today | 07:16 |
| mvo | mborzecki: thank you | 07:19 |
| === pedronis_ is now known as pedronis | ||
| zyga | good morning | 07:51 |
| zyga | sorry for starting late, I woke up very early due to pain and then tired to sleep again after taking painkillers | 07:52 |
| mup | PR core18#159 closed: 030-fix-timedatectl.chroot: fix quoting issues <Created by mvo5> <Merged by sil2100> <https://github.com/snapcore/core18/pull/159> | 08:41 |
| zyga | drat, lucy just walked over the keyboard and sigquit spread | 09:31 |
| pstolowski | zyga: haha | 09:52 |
| zyga | what are the chances... | 09:54 |
| * zyga is debugging some weird failures | 09:57 | |
| zyga | mborzecki: something weird is going on in feature/track-launched-apps on tumbleweed | 10:06 |
| zyga | on master that test passes | 10:07 |
| zyga | on the feature branch it fails | 10:07 |
| zyga | as if making the transient scope actually affected the existing tracking using the pid cgroup | 10:07 |
| zyga | but why only on tumbleweed? | 10:07 |
| * zyga investigates | 10:07 | |
| zyga | maybe they moved to cgroupv2? | 10:08 |
| zyga | notably the test does not fail in the big branch where we use the new information for the same decision | 10:08 |
| zyga | so maybe ...? | 10:08 |
| zyga | baaah | 10:25 |
| zyga | and now it passes | 10:25 |
| zyga | what the heck?! | 10:25 |
| * zyga thinks and tries to drink coffee | 10:26 | |
| mborzecki | ok, docs updated, now onto the reviews | 10:34 |
| * sdhd-sascha Ooh, too much beer yesterday | 10:35 | |
| zyga | mborzecki: thanks | 10:36 |
| mborzecki | zyga: can you review https://github.com/snapcore/snapd/pull/8883 ? | 11:01 |
| mup | PR #8883: packaging: stop snapd early on purge <Test Robustness> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8883> | 11:01 |
| zyga | mborzecki: after the call | 11:07 |
| zyga | mborzecki: https://github.com/snapcore/snapd/pull/8883/checks?check_run_id=845292346 fails | 11:22 |
| mup | PR #8883: packaging: stop snapd early on purge <Test Robustness> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8883> | 11:22 |
| mborzecki | uh, 14.40 | 11:23 |
| mborzecki | pff fun | 11:23 |
| zyga | re | 12:02 |
| zyga | mborzecki: ping me when ready | 12:02 |
| zyga | I'm debugging something related to old tracking | 12:02 |
| ijohnson|sprint | mborzecki: took a real quick look at your doc | 12:03 |
| mborzecki | ijohnson|sprint: hey, thanks | 12:13 |
| zyga | eh, I add logging and now it passes | 12:31 |
| zyga | there must be something racy there | 12:31 |
| zyga | all right, it failed now | 12:32 |
| zyga | ahh, I have a feeling I know what's wrong | 12:34 |
| zyga | mborzecki: heh, start transient scope keeps on giving | 12:57 |
| * zyga thinks | 12:57 | |
| zyga | thinks it's time to join the call | 12:58 |
| mborzecki | heh ;) | 12:58 |
| mup | PR snapd#8986 opened: tests: new snaps-state command - part1 <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8986> | 13:03 |
| ijohnson|sprint | zyga: I managed to fix my layout verification PR, it was as expected to use Layout.Path instead of the key in the map | 13:13 |
| zyga | thanks! | 13:13 |
| mvo | ondra: hey, I played with the latest go which has some linker improvements - the snap-bootstrap binary is down from 11mb stripped to 7.7mb stripped. so low mem snapd looks more feasible | 13:42 |
| * zyga break for meds and some rest | 13:59 | |
| * cachio lunch | 15:37 | |
| pstolowski | cachio: +1 for your 'run nested' pr, please ping someone for 2nd review | 15:55 |
| cachio | Psi-Jack, thanks | 16:38 |
| Psi-Jack | What? | 16:38 |
| ogra | just take the credit, don't complain ... | 16:55 |
| cachio | Psi-Jack, sorry, was pstolowski but he quited | 16:55 |
| Psi-Jack | lol | 16:56 |
| cachio | Psi-Jack, I think it is the seconds time I do the same | 16:56 |
| cachio | hehe | 16:56 |
| Psi-Jack | Yep! | 16:57 |
| * zyga tested 16.04 and 18.04 and systemd is not racy there | 17:16 | |
| zyga | trying 20.04 and adding workaround in software on our side | 17:16 |
| zyga | 20.04 also passes, trying 20.10 which should be close to sid | 17:28 |
| zyga | but this suggests either a regression in systemd | 17:28 |
| zyga | or a "feature" | 17:28 |
| zyga | 20.10 testing now.. | 17:44 |
| zyga | amd it seems to pass | 17:44 |
| zyga | maybe we have patches in systemd | 17:44 |
| zyga | jdstrand: ^ more tracking mystery | 17:44 |
| zyga | going to test debian-9 vs sid | 17:47 |
| sdhd-sascha | hey people, i really regret my level of alcohol, yesterday ;-) sorry ;-) | 17:53 |
| ogra | it was rather obvious 🙂 | 17:54 |
| sdhd-sascha | ogra: thank you ;-) i try to go another way in future ;-) | 17:57 |
| sdhd-sascha | did anybody mention the birds, and there song's? here in bavaria, they decrease volume. Then after lockdown they increase there songs... And now, they have learn both ;-) | 18:01 |
| zyga | hmm, debian, even sid does not fail, so it is really just tumbleweed or was my sample size too small | 18:08 |
| mup | PR snapd#8907 closed: asserts: implement Database.FindSequence <validation-sets :white_check_mark:> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/8907> | 18:09 |
| sdhd-sascha | ogra: i share your love for graph-algos . But didn't have a hint how to optimize it?! | 18:09 |
| cachio | zyga, hi | 18:10 |
| zyga | cachio: hi | 18:11 |
| cachio | I was checking and to run shellcheck on tools tests we need to install the shellcheck snap | 18:11 |
| cachio | but for that we need to have the snap command available | 18:11 |
| cachio | zyga, does it make sense? | 18:11 |
| zyga | cachio: yes, I ran into this myself, it's not fortunate but perhaps unavoidable | 18:12 |
| cachio | zyga, currently we prepare the suite with --prepare-suite-each-minimal-no-snaps | 18:12 |
| zyga | cachio: alternatively, don't install it | 18:12 |
| zyga | cachio: but install it only on one system | 18:12 |
| zyga | cachio: and run shellcheck e.g. only on ubuntu 20.04 | 18:12 |
| zyga | this way we test on more systems | 18:12 |
| zyga | and shellcheck at least once | 18:12 |
| zyga | note that that suite does not have full snapd ready | 18:12 |
| zyga | so it may not be possible to install snaps | 18:13 |
| cachio | but then we also need to have snap to test the snaps tool that I just created | 18:13 |
| sdhd-sascha | ooh, just a "deb" problem ? or others have that too? | 18:13 |
| cachio | zyga, but for that I could install snapd and then purge | 18:13 |
| zyga | cachio: hmmm | 18:14 |
| zyga | cachio: perhaps the snap helper needs different strategy | 18:14 |
| zyga | cachio: for generic helpers I would not install snapd | 18:14 |
| zyga | cachio: perhaps the snap helper needs to live in main | 18:14 |
| zyga | (as in tests) | 18:14 |
| mup | PR snapd#8984 closed: asserts: integer headers: disallow prefix zeros and make parsing more uniform <validation-sets :white_check_mark:> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/8984> | 18:14 |
| cachio | zyga, you need the test | 18:14 |
| sdhd-sascha | cachio: i love purge... But there was a AI, which should sort a list. The AI has won, with purging the complete list ;-) | 18:14 |
| cachio | zyga, so I'll move the test to main in that case | 18:15 |
| zyga | cachio: I think that's better | 18:15 |
| cachio | zyga, good | 18:15 |
| zyga | thanks! | 18:16 |
| zyga | what's the name of the tool btw? | 18:16 |
| cachio | snaps-state | 18:17 |
| ogra | schnaps-state ... | 18:18 |
| cachio | zyga, but it could change | 18:18 |
| zyga | cachio: do you want it to be on PATH? | 18:18 |
| zyga | cachio: note that the naming rules differ between the two | 18:18 |
| cachio | zyga, no | 18:18 |
| cachio | just to be on path when we debug | 18:18 |
| zyga | ok | 18:18 |
| zyga | hmm? | 18:18 |
| zyga | how would that work? | 18:18 |
| cachio | I'll use it like $TESTSTOOLS"/snap-state | 18:19 |
| cachio | so it should be fine | 18:19 |
| zyga | I see | 18:19 |
| zyga | if you want it on path it could be called tests.snap or something like that | 18:20 |
| zyga | I think that's okay too | 18:20 |
| zyga | no strong opinion either way | 18:20 |
| cachio | ok, so far it is ok | 18:24 |
| cachio | having this "$TESTSTOOLS"/snap-state is it ok | 18:24 |
| cachio | zyga, also we could have a test targeted to ubuntu-18.04 which runs shellcheck for all the bash files in tools | 18:30 |
| zyga | cachio: I think we kind of do that already (perhaps) via run-checks but yeah | 18:31 |
| zyga | but I really prefer each tool test to check itself | 18:31 |
| zyga | then it's obvious | 18:31 |
| cachio | ok | 18:31 |
| sdhd-sascha | zyga: cachio: hey, at high-level language, it's possible to write once, and work everywhere ;-) | 18:31 |
| * sdhd-sascha short afk | 18:33 | |
| mup | PR snapcraft#3205 opened: spread tests: higher timeout for extension tests <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3205> | 18:56 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!