| mup | PR snapcraft#2568 closed: docs: consolidate on a simple HACKING.md <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2568> | 00:07 |
|---|---|---|
| === jamesh_ is now known as jamesh | ||
| mborzecki | morning | 05:06 |
| zyga | Hey mborzecki | 06:00 |
| mborzecki | zyga: hey | 06:00 |
| mborzecki | zyga: how's your day off coming? :) | 06:00 |
| zyga | Haha | 06:00 |
| zyga | I was just wondering the same thing | 06:00 |
| zyga | Should I take today off for real | 06:00 |
| zyga | Or work some more to get stuff done | 06:00 |
| zyga | So many things to work on | 06:01 |
| zyga | mborzecki: I sent a small patch for spread-shellcheck | 06:05 |
| zyga | And had an idea on how to fix not MATCH | 06:05 |
| zyga | We can save MATCH to lib/bin on startup | 06:07 |
| zyga | Like we do now to match.sh include file | 06:07 |
| zyga | Since it is on path it will be more flexible | 06:07 |
| zyga | Then MATCH is no longer a function | 06:08 |
| zyga | Then we can put “not” on path and fix all tests | 06:08 |
| mborzecki | zyga: in other news, got an image built by snap-image (strawman) to boot up to a point where i got console conf :P | 06:15 |
| zyga | Wooooot | 06:16 |
| zyga | That is great | 06:16 |
| zyga | It still feels that landing your changes will take a month | 06:17 |
| mborzecki | yeah, and tests and all that | 06:17 |
| mborzecki | zyga: if you guys have a system-rescue role that you'd like me to add or something, this coudl be done really easily | 06:18 |
| zyga | Role as in partition type? | 06:19 |
| zyga | I think we should talk about how the recovery system is designed, so far, to keep you in the loop | 06:19 |
| mborzecki | zyga: role as role in gadget.yaml terms, and whatever that means practically, eg. like system-boot is a bit special | 06:19 |
| mborzecki | zyga: and so is system-data | 06:19 |
| zyga | I think some things there will change | 06:20 |
| zyga | Though I think that is best for next week | 06:20 |
| zyga | re, back in the office | 06:37 |
| zyga | mborzecki: can you do a quick review of https://github.com/snapcore/snapd/pull/6906 | 06:38 |
| zyga | just a variable rename | 06:38 |
| mup | PR #6906: cmd/snap-update-ns: rename ctx to upCtx <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6906> | 06:38 |
| zyga | though more importantly I need a review for https://github.com/snapcore/snapd/pull/6903 to get 2.39.1 fix in place | 06:38 |
| mup | PR #6903: spread-shellcheck: add support for variants and environment <Created by zyga> <https://github.com/snapcore/snapd/pull/6903> | 06:38 |
| zyga | the shellcheck change is not perfect | 06:38 |
| zyga | but it's also not totally incorrect | 06:38 |
| zyga | and allows my tests to not get stuck on that | 06:38 |
| * zyga quick coffee | 07:01 | |
| zyga | mborzecki: if you can review the spread-shellcheck change I will be able to propose the propagation fixes | 07:01 |
| zyga | I will do some branch gardening soon | 07:03 |
| zyga | but first coffee | 07:03 |
| pstolowski|afk | morning | 07:04 |
| === pstolowski|afk is now known as pstolowski | ||
| zyga | Hey :-) | 07:09 |
| zyga | Interesting https://forum.snapcraft.io/t/snapshots-can-expose-sensitive-data/11493 | 07:19 |
| pstolowski | zyga: hmm interesting indeed | 07:27 |
| mup | PR snapd#6906 closed: cmd/snap-update-ns: rename ctx to upCtx <Simple 😃> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6906> | 07:27 |
| zyga | makes me feel that snapshots should be saved back to $HOME | 07:27 |
| zyga | as anything else is not correct wrt NFS and encryption | 07:27 |
| zyga | pstolowski: quick trivial https://github.com/snapcore/snapd/pull/6907 | 07:28 |
| mup | PR #6907: cmd/snap-update-ns: add several TODO comments <Created by zyga> <https://github.com/snapcore/snapd/pull/6907> | 07:28 |
| zyga | just comments | 07:28 |
| zyga | but that's *all* of the refactoring :D | 07:28 |
| zyga | wooooot | 07:28 |
| mup | PR snapd#6907 opened: cmd/snap-update-ns: add several TODO comments <Created by zyga> <https://github.com/snapcore/snapd/pull/6907> | 07:28 |
| pstolowski | +1§ | 07:29 |
| mborzecki | pstolowski: hey | 07:30 |
| pstolowski | o/ | 07:30 |
| mup | PR snapd#6894 closed: tests: add "not" command as replacement for "!" in tests <Created by zyga> <Closed by zyga> <https://github.com/snapcore/snapd/pull/6894> | 07:40 |
| mup | PR snapd#6908 opened: tests: add "not" command <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6908> | 07:44 |
| zyga | mborzecki, pstolowski: how do you feel about ^ not | 08:05 |
| zyga | I want to build this on top https://github.com/snapcore/snapd/pull/6909 | 08:05 |
| mup | PR #6909: spread.yaml,tests: change MATCH and REBOOT to cmds <Created by zyga> <https://github.com/snapcore/snapd/pull/6909> | 08:05 |
| zyga | and then fix our scripts to use not rather than ! | 08:05 |
| mup | PR snapd#6909 opened: spread.yaml,tests: change MATCH and REBOOT to cmds <Created by zyga> <https://github.com/snapcore/snapd/pull/6909> | 08:06 |
| pstolowski | zyga: interesting; don't we still need to make it a compound expressionm e.g. { ! "$@" } ? | 08:11 |
| zyga | no, why? | 08:11 |
| zyga | ! functions correctly | 08:12 |
| zyga | note that this executable is not sourced, it's a program that runs without set -e | 08:12 |
| pstolowski | zyga: ok, so -e is the key here. i was reading also https://stackoverflow.com/questions/39581150/why-do-i-need-parenthesis-in-bash-set-e-and-negated-return-code/39582012 | 08:12 |
| === icey_ is now known as icey | ||
| zyga | I wonder if snapd is going to get any sponsors: https://techcrunch.com/2019/05/23/github-launches-sponsors-lets-you-pay-your-favorite-open-source-contributors/ | 08:22 |
| zyga | mborzecki: https://github.com/google/pytype | 08:40 |
| zyga | mborzecki: from that video you linkedto | 08:40 |
| zyga | mborzecki: updated https://github.com/snapcore/snapd/pull/6903 | 08:51 |
| mup | PR #6903: spread-shellcheck: add support for variants and environment <Created by zyga> <https://github.com/snapcore/snapd/pull/6903> | 08:51 |
| mborzecki | zyga: nhm, lgtm | 08:55 |
| zyga | nhm? | 08:56 |
| zyga | mborzecki: something for you :) https://github.com/snapcore/snapd/pull/6910 | 09:00 |
| mup | PR #6910: spread.yaml: use "snap connections" in debug <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6910> | 09:00 |
| mup | PR snapd#6910 opened: spread.yaml: use "snap connections" in debug <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6910> | 09:00 |
| * zyga really gets that coffee now | 09:03 | |
| zyga | after the break I will try to land "not" and "MATCH" as commands and see if I can fix ! tree-wide | 09:03 |
| zyga | and revert shellcheck patch so that we track edge again | 09:03 |
| zyga | back now :) | 09:17 |
| zyga | aaaand, "not" is red | 09:17 |
| mup | PR snapd#6907 closed: cmd/snap-update-ns: add several TODO comments <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6907> | 09:20 |
| pstolowski | and i just had google:ubuntu-14.04-64:tests/main/parallel-install-aliases failure on one of my PRs | 09:35 |
| pstolowski | never seen it failing | 09:35 |
| zyga | pstolowski: how did it fail? | 09:38 |
| pstolowski | zyga: it was expecting the change to fail with 'cannot enable alias "alias1" for "aliases_foo", already enabled for "aliases"', but instead got 'Done today at 15:27 UTC today at 15:27 UTC Setup manual alias "alias1" => "cmd1" for snap "aliases"' | 09:40 |
| pstolowski | zyga: i wonder it snap change --last=alias check there isn't racy | 09:40 |
| zyga | huh, I saw that fail once as well | 09:41 |
| zyga | yesterday | 09:41 |
| pstolowski | because just above we test happy execution | 09:41 |
| pstolowski | zyga: i'll kick it again on travis and in the meantime execute and investigate it locally | 09:41 |
| zyga | k | 09:41 |
| pstolowski | and if that's it, will fix it | 09:42 |
| zyga | pstolowski: can you look at https://github.com/snapcore/snapd/pull/6903 | 09:42 |
| mup | PR #6903: spread-shellcheck: add support for variants and environment <Created by zyga> <https://github.com/snapcore/snapd/pull/6903> | 09:42 |
| pstolowski | k | 09:42 |
| zyga | I need a 2nd review to open the fix for the mount propagation PR | 09:42 |
| zyga | mborzecki: curious, permissions package seems to be updated with some snapd bits | 09:52 |
| zyga | as a simple build in obs failed on that | 09:52 |
| * zyga looks | 09:52 | |
| zyga | settle not converging | 09:53 |
| * zyga loves when unit tests fail | 09:53 | |
| zyga | pstolowski: does this sound familiar? | 09:54 |
| zyga | https://www.irccloud.com/pastebin/02IEvvjO/ | 09:54 |
| zyga | ah, this is device registration, not hotplug | 09:55 |
| zyga | sorry | 09:55 |
| zyga | bah | 09:55 |
| zyga | this happens each time | 09:56 |
| * zyga debugs | 09:56 | |
| mup | PR snapd#6893 closed: gadget: helper for shifting structure start position <Gadget update> <Simple 😃> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/6893> | 10:01 |
| zyga | hrm | 10:01 |
| zyga | go test passes on my tree with 2.39 | 10:01 |
| zyga | fails in the tarball | 10:01 |
| zyga | whhyyyyy | 10:01 |
| zyga | hmmm | 10:05 |
| zyga | I disabled unit tests and installed the resulting package | 10:14 |
| zyga | let's see how it operates | 10:14 |
| zyga | then I can see why they fail again | 10:14 |
| zyga | eh | 10:20 |
| zyga | in x11 mode I don't have /snap/bin on path | 10:20 |
| zyga | in wayland mode some apps just crash | 10:20 |
| zyga | lovely | 10:20 |
| zyga | after reboot things seem to be have | 10:23 |
| zyga | behave even | 10:23 |
| pstolowski | zyga: hmm somewhat, seen failures like this from time to time while working on these tests, usually was a race. you're saying it fails each time like this? | 10:35 |
| zyga | do you remember https://github.com/snapcore/snapd/pull/6360 <- I just merged master into it :) | 10:35 |
| mup | PR #6360: cmd/snap-update-ns: refactor of profile application <Per-user mount ns 🐎> <Created by zyga> <https://github.com/snapcore/snapd/pull/6360> | 10:35 |
| zyga | pstolowski: yeah | 10:35 |
| zyga | but only in packaging build | 10:35 |
| zyga | not in a checkout | 10:35 |
| zyga | I didn't look deeper yet | 10:35 |
| zyga | "not" failed again | 10:36 |
| pstolowski | zyga: on which test? | 10:37 |
| zyga | service watchdog | 10:37 |
| pstolowski | zyga: +1 on 6903 with a question | 10:51 |
| zyga | looking | 10:51 |
| pstolowski | of course parallel-install-aliases is passing when run locally... will keep it running during lunch | 10:55 |
| zyga | pstolowski: replied there | 10:56 |
| pstolowski | ty | 11:00 |
| * pstolowski lunch | 11:00 | |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!