mupPR snapcraft#2568 closed: docs: consolidate on a simple HACKING.md <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2568>00:07
=== jamesh_ is now known as jamesh
zygaHey mborzecki06:00
mborzeckizyga: hey06:00
mborzeckizyga: how's your day off coming? :)06:00
zygaI was just wondering the same thing06:00
zygaShould I take today off for real06:00
zygaOr work some more to get stuff done06:00
zygaSo many things to work on06:01
zygamborzecki: I sent a small patch for spread-shellcheck06:05
zygaAnd had an idea on how to fix not MATCH06:05
zygaWe can save MATCH to lib/bin on startup06:07
zygaLike we do now to match.sh include file06:07
zygaSince it is on path it will be more flexible06:07
zygaThen MATCH is no longer a function06:08
zygaThen we can put โ€œnotโ€ on path and fix all tests06:08
mborzeckizyga: in other news, got an image built by snap-image (strawman) to boot up to a point where i got console conf :P06:15
zygaThat is great06:16
zygaIt still feels that landing your changes will take a month06:17
mborzeckiyeah, and tests and all that06:17
mborzeckizyga: if you guys have a system-rescue role that you'd like me to add or something, this coudl be done really easily06:18
zygaRole as in partition type?06:19
zygaI think we should talk about how the recovery system is designed, so far, to keep you in the loop06:19
mborzeckizyga: role as role in gadget.yaml terms, and whatever that means practically, eg. like system-boot is a bit special06:19
mborzeckizyga: and so is system-data06:19
zygaI think some things there will change06:20
zygaThough I think that is best for next week06:20
zygare, back in the office06:37
zygamborzecki: can you do a quick review of https://github.com/snapcore/snapd/pull/690606:38
zygajust a variable rename06:38
mupPR #6906: cmd/snap-update-ns: rename ctx to upCtx <Simple ๐Ÿ˜ƒ> <Created by zyga> <https://github.com/snapcore/snapd/pull/6906>06:38
zygathough more importantly I need a review for https://github.com/snapcore/snapd/pull/6903 to get 2.39.1 fix in place06:38
mupPR #6903: spread-shellcheck: add support for variants and environment <Created by zyga> <https://github.com/snapcore/snapd/pull/6903>06:38
zygathe shellcheck change is not perfect06:38
zygabut it's also not totally incorrect06:38
zygaand allows my tests to not get stuck on that06:38
* zyga quick coffee07:01
zygamborzecki: if you can review the spread-shellcheck change I will be able to propose the propagation fixes07:01
zygaI will do some branch gardening soon07:03
zygabut first coffee07:03
=== pstolowski|afk is now known as pstolowski
zygaHey :-)07:09
zygaInteresting https://forum.snapcraft.io/t/snapshots-can-expose-sensitive-data/1149307:19
pstolowskizyga: hmm interesting indeed07:27
mupPR snapd#6906 closed: cmd/snap-update-ns: rename ctx to upCtx <Simple ๐Ÿ˜ƒ> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6906>07:27
zygamakes me feel that snapshots should be saved back to $HOME07:27
zygaas anything else is not correct wrt NFS and encryption07:27
zygapstolowski: quick trivial https://github.com/snapcore/snapd/pull/690707:28
mupPR #6907: cmd/snap-update-ns: add several TODO comments <Created by zyga> <https://github.com/snapcore/snapd/pull/6907>07:28
zygajust comments07:28
zygabut that's *all* of the refactoring :D07:28
mupPR snapd#6907 opened: cmd/snap-update-ns: add several TODO comments <Created by zyga> <https://github.com/snapcore/snapd/pull/6907>07:28
mborzeckipstolowski: hey07:30
mupPR snapd#6894 closed: tests: add "not" command as replacement for "!" in tests <Created by zyga> <Closed by zyga> <https://github.com/snapcore/snapd/pull/6894>07:40
mupPR snapd#6908 opened: tests: add "not" command <Simple ๐Ÿ˜ƒ> <Created by zyga> <https://github.com/snapcore/snapd/pull/6908>07:44
zygamborzecki, pstolowski: how do you feel about ^ not08:05
zygaI want to build this on top  https://github.com/snapcore/snapd/pull/690908:05
mupPR #6909: spread.yaml,tests: change MATCH and REBOOT to cmds <Created by zyga> <https://github.com/snapcore/snapd/pull/6909>08:05
zygaand then fix our scripts to use not rather than !08:05
mupPR snapd#6909 opened: spread.yaml,tests: change MATCH and REBOOT to cmds <Created by zyga> <https://github.com/snapcore/snapd/pull/6909>08:06
pstolowskizyga: interesting; don't we still need to make it a compound expressionm e.g. { ! "$@" } ?08:11
zygano,  why?08:11
zyga! functions correctly08:12
zyganote that this executable is not sourced, it's a program that runs without set -e08:12
pstolowskizyga: ok, so -e is the key here. i was reading also https://stackoverflow.com/questions/39581150/why-do-i-need-parenthesis-in-bash-set-e-and-negated-return-code/3958201208:12
=== icey_ is now known as icey
zygaI wonder if snapd is going to get any sponsors: https://techcrunch.com/2019/05/23/github-launches-sponsors-lets-you-pay-your-favorite-open-source-contributors/08:22
zygamborzecki: https://github.com/google/pytype08:40
zygamborzecki: from that video you linkedto08:40
zygamborzecki: updated https://github.com/snapcore/snapd/pull/690308:51
mupPR #6903: spread-shellcheck: add support for variants and environment <Created by zyga> <https://github.com/snapcore/snapd/pull/6903>08:51
mborzeckizyga: nhm, lgtm08:55
zygamborzecki: something for you :) https://github.com/snapcore/snapd/pull/691009:00
mupPR #6910: spread.yaml: use "snap connections" in debug <Simple ๐Ÿ˜ƒ> <Created by zyga> <https://github.com/snapcore/snapd/pull/6910>09:00
mupPR snapd#6910 opened: spread.yaml: use "snap connections" in debug <Simple ๐Ÿ˜ƒ> <Created by zyga> <https://github.com/snapcore/snapd/pull/6910>09:00
* zyga really gets that coffee now09:03
zygaafter the break I will try to land "not" and "MATCH" as commands and see if I can fix ! tree-wide09:03
zygaand revert shellcheck patch so that we track edge again09:03
zygaback now :)09:17
zygaaaaand, "not" is red09:17
mupPR snapd#6907 closed: cmd/snap-update-ns: add several TODO comments <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6907>09:20
pstolowskiand i just had google:ubuntu-14.04-64:tests/main/parallel-install-aliases failure on one of my PRs09:35
pstolowskinever seen it failing09:35
zygapstolowski: how did it fail?09:38
pstolowskizyga: it was expecting the change to fail with 'cannot enable alias "alias1" for "aliases_foo", already enabled for "aliases"', but instead got 'Done    today at 15:27 UTC  today at 15:27 UTC  Setup manual alias "alias1" => "cmd1" for snap "aliases"'09:40
pstolowskizyga: i wonder it snap change --last=alias check there isn't racy09:40
zygahuh, I saw that fail once as well09:41
pstolowskibecause just above we test happy execution09:41
pstolowskizyga: i'll kick it again on travis and in the meantime execute and investigate it locally09:41
pstolowskiand if that's it, will fix it09:42
zygapstolowski: can you look at https://github.com/snapcore/snapd/pull/690309:42
mupPR #6903: spread-shellcheck: add support for variants and environment <Created by zyga> <https://github.com/snapcore/snapd/pull/6903>09:42
zygaI need a 2nd review to open the fix for the mount propagation PR09:42
zygamborzecki: curious, permissions package seems to be updated with some snapd bits09:52
zygaas a simple build in obs failed on that09:52
* zyga looks09:52
zygasettle not converging09:53
* zyga loves when unit tests fail09:53
zygapstolowski: does this sound familiar?09:54
zygaah, this is device registration, not hotplug09:55
zygathis happens each time09:56
* zyga debugs09:56
mupPR snapd#6893 closed: gadget: helper for shifting structure start position <Gadget update> <Simple ๐Ÿ˜ƒ> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/6893>10:01
zygago test passes on my tree with 2.3910:01
zygafails in the tarball10:01
zygaI disabled unit tests and installed the resulting package10:14
zygalet's see how it operates10:14
zygathen I can see why they fail again10:14
zygain x11 mode I don't have /snap/bin on path10:20
zygain wayland mode some apps just crash10:20
zygaafter reboot things seem to be have10:23
zygabehave even10:23
pstolowskizyga: hmm somewhat, seen failures like this from time to time while working on these tests, usually was a race. you're saying it fails each time like this?10:35
zygado you remember https://github.com/snapcore/snapd/pull/6360 <- I just merged master into it :)10:35
mupPR #6360: cmd/snap-update-ns: refactor of profile application <Per-user mount ns  ๐ŸŽ> <Created by zyga> <https://github.com/snapcore/snapd/pull/6360>10:35
zygapstolowski: yeah10:35
zygabut only in packaging build10:35
zyganot in a checkout10:35
zygaI didn't look deeper yet10:35
zyga"not" failed again10:36
pstolowskizyga: on which test?10:37
zygaservice watchdog10:37
pstolowskizyga: +1 on 6903 with a question10:51
pstolowskiof course parallel-install-aliases is passing when run locally... will keep it running during lunch10:55
zygapstolowski: replied there10:56
* pstolowski lunch11:00

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!