| jamesh | mwhudson: looks like the problem https://github.com/snapcore/snapcraft/pull/3498 is supposed to fix. edge snapcraft might let you close the channel | 04:54 |
|---|---|---|
| mup | PR snapcraft#3498: storeapi: set content-type and accept headers for close <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3498> | 04:54 |
| jamesh | seems like a bit of a problem that the tool is trailing the changes in the store rather than leading | 04:55 |
| mborzecki | morning | 05:49 |
| zyga | good morning | 07:14 |
| mborzecki | zyga: hey | 07:16 |
| mvo | good morning zyga and mborzecki. happy monday! | 07:16 |
| mborzecki | mvo: hey, good morning | 07:16 |
| mborzecki | mvo: fyi, this PR can land https://github.com/snapcore/snapd/pull/10128 | 07:17 |
| mup | PR #10128: tests: add 20.04 to systems for nested/core <Run nested> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10128> | 07:17 |
| mvo | mborzecki: cool | 07:18 |
| mborzecki | mvo: can you take a look at https://github.com/snapcore/snapd/pull/10120 ? | 07:19 |
| mup | PR #10120: boot: derive boot variables for kernel command lines <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10120> | 07:19 |
| mvo | mborzecki: sure | 07:19 |
| mborzecki | should be fairly simple, it there's some post merge comments from pedronis we can address those in a followup | 07:20 |
| mup | PR snapd#10132 closed: boot,tests: move where we write boot-flags one level up <Squash-merge> <UC20> <Created by pedronis> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10132> | 07:21 |
| mborzecki | mvo: thanks! would you like to take a look at https://github.com/snapcore/snapd/pull/10129 too? builds on top of the previous one | 07:29 |
| mup | PR #10129: boot: set extra kernel command line arguments when making a recovery system bootable <Run nested> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10129> | 07:29 |
| mvo | sure | 07:30 |
| mborzecki | thanks! | 07:30 |
| mup | PR snapd#10120 closed: boot: derive boot variables for kernel command lines <Simple 😃> <Skip spread> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/10120> | 07:31 |
| mvo | mborzecki: done, how much extra work will run-mode support be? | 07:33 |
| mborzecki | mvo: i need this to land to open the next PR: https://github.com/snapcore/snapd/pull/10130 (or at least https://github.com/snapcore/snapd/pull/10119 so that there wont' be too many prs open) | 07:38 |
| mup | PR #10130: boot: load bits of kernel command line from gadget snaps <Run nested> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10130> | 07:38 |
| mup | PR #10119: boot: pass gadget path to command line helpers, load gadget from seed <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10119> | 07:38 |
| mvo | mborzecki: anything there I could review and help with? | 07:45 |
| mborzecki | mvo: maybe you could also take a look at https://github.com/snapcore/snapd/pull/10119 then? | 07:46 |
| mup | PR #10119: boot: pass gadget path to command line helpers, load gadget from seed <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10119> | 07:46 |
| jamesh | anyone up for a second review of https://github.com/snapcore/snapd/pull/10126 ? It's a fairly short and simple cleanup | 08:28 |
| mup | PR #10126: daemon: make ucrednetGet() return a *ucrednet structure <Simple 😃> <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/10126> | 08:28 |
| pedronis | was about to mention it as well | 08:35 |
| pedronis | jamesh: it's merged now | 08:39 |
| jamesh | pedronis, mborzecki: thanks! | 08:40 |
| mup | PR snapd#10126 closed: daemon: make ucrednetGet() return a *ucrednet structure <Simple 😃> <Created by jhenstridge> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/10126> | 08:41 |
| mborzecki | pedronis: can you take another look at https://github.com/snapcore/snapd/pull/10119 ? | 08:51 |
| mup | PR #10119: boot: pass gadget path to command line helpers, load gadget from seed <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10119> | 08:51 |
| pedronis | mborzecki: yes, was about to, it's near the top of my queue | 08:51 |
| mborzecki | pedronis: cool, thank you | 08:52 |
| mup | PR snapd#10131 closed: tests: new os.paths tool <Created by sergiocazzolato> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/10131> | 08:56 |
| mup | PR snapd#10123 closed: boot,gadget,devicestate: create "aux-key" for fde-hooks v2 <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/10123> | 09:01 |
| pedronis | mborzecki: could you merge master into https://github.com/snapcore/snapd/pull/10129 | 09:11 |
| mup | PR #10129: boot: set extra kernel command line arguments when making a recovery system bootable <Run nested> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10129> | 09:11 |
| mborzecki | pedronis: sure, just a sec | 09:12 |
| mborzecki | pedronis: done | 09:13 |
| pedronis | mborzecki: it's the extra args case complete with 10130 or there is more even for that? | 09:35 |
| mborzecki | pedronis: there's a change in MakeSystemRunnable(), another one in update boot config, a helper for handling update of bits that contribute to command line, and changes in devicestate, although all of that is for both extra and full cmdlines | 09:37 |
| pedronis | ah, ok, so still quite a bit of stuff | 09:38 |
| mup | PR snapd#10119 closed: boot: pass gadget path to command line helpers, load gadget from seed <Simple 😃> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10119> | 09:41 |
| mborzecki | heh running a nested test with tpm and secure boot, the qemu cpu is resetting | 10:35 |
| mup | PR snapd#10129 closed: boot: set extra kernel command line arguments when making a recovery system bootable <Run nested> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/10129> | 10:37 |
| mup | PR snapd#10134 opened: boot: set extra command line arguments when preparing run mode <Run nested> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10134> | 11:12 |
| mborzecki | hmmm 10134 works locally with secure boot, but fails on google | 11:23 |
| mborzecki | mvo: can you take a look at https://github.com/snapcore/snapd/pull/10135 ? i started doubting myself tbh | 11:45 |
| mup | PR #10135: tests/lib/nested: proper status return for tpm/secure boot checks <Run nested> <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10135> | 11:45 |
| mup | PR snapd#10135 opened: tests/lib/nested: proper status return for tpm/secure boot checks <Run nested> <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10135> | 11:47 |
| mvo | mborzecki: will do after lunch | 11:51 |
| mborzecki | thanks! | 11:51 |
| mborzecki | cachio_: have you seen: 2021-04-12 10:03:19 Cannot allocate google-nested:ubuntu-18.04-64: cannot find any Google image matching "ubuntu-1804-64-virt-enabled" on project "computeengine" or "ubuntu-os-cloud" | 11:54 |
| mborzecki | it's in https://github.com/snapcore/snapd/runs/2322682467 | 11:54 |
| cachio_ | mborzecki, hi, let me fix that | 11:54 |
| mborzecki | cachio_: also os.query seems to be failing on debian sid, as if it's not sid anymore 😉 https://paste.ubuntu.com/p/C9xsyhZ8Jd/ | 11:55 |
| mborzecki | maybe they've bumped os-release or something | 11:55 |
| mborzecki | or we're using the wrong image :/ | 11:56 |
| cachio_ | mborzecki, images fixed | 11:56 |
| cachio_ | let me check sic image | 11:57 |
| cachio_ | sid | 11:57 |
| cachio_ | thanks for let me know | 11:57 |
| cachio_ | mborzecki, so now debian sid is VERSION_CODENAME=bullseye | 12:03 |
| cachio_ | this is why os.query is failing | 12:03 |
| cachio_ | I need to create a new image I see | 12:05 |
| cachio_ | mvo, hi, should we support debian 11? | 12:06 |
| mborzecki | hmm, maybe there's other way tell it's debian sid? | 12:06 |
| mborzecki | merging some of my branches in isolation, broke master https://github.com/snapcore/snapd/pull/10136 fixes it | 12:10 |
| mup | PR #10136: boot: drop gadget snap yaml which is already defined elsewhere in the tests <Skip spread> <âš Critical> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10136> | 12:10 |
| mup | PR snapd#10136 opened: boot: drop gadget snap yaml which is already defined elsewhere in the tests <Skip spread> <âš Critical> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10136> | 12:12 |
| mup | PR snapd#10136 closed: boot: drop gadget snap yaml which is already defined elsewhere in the tests <Skip spread> <âš Critical> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10136> | 13:27 |
| mup | PR snapd#10047 closed: tests: remove the snap profiler from the test suite <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10047> | 13:42 |
| mup | PR snapd#10137 opened: tests: update os.query check to match new bullseye codename used on sid images <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10137> | 14:02 |
| * cachio_ afk | 14:22 | |
| ijohnson | cachio_: do you know if our ubuntu core spread GCE environments would have virtual network interfaces that don't have MAC addresses? if so then the tests/core/netplan failures we are seeing may be from https://bugs.launchpad.net/ubuntu/+source/netplan.io/+bug/1913062 | 14:43 |
| mup | Bug #1913062: netplan apply backtrace <amd64> <apport-bug> <focal> <uec-images> <netplan.io (Ubuntu):Triaged> <https://launchpad.net/bugs/1913062> | 14:43 |
| ijohnson | cachio_: if so I have a workaround from paul that might avoid the issue before the fix is released | 15:02 |
| === pedronis_ is now known as pedronis | ||
| cachio_ | ijohnson, hey, sorry, didn't see what youwrote | 15:56 |
| ijohnson | cachio_: sure let me re-send it | 15:57 |
| cachio_ | let me check | 15:57 |
| ijohnson | oh did you see the message ? | 15:57 |
| cachio_ | didn't see the notificatin | 15:57 |
| cachio_ | let me check the mac address for uc | 15:57 |
| cachio_ | ijohnson, uc16 right? | 15:58 |
| ijohnson | cachio_: I have seen it on uc20 too I think | 15:58 |
| cachio_ | I see in the bug DistroRelease: Ubuntu 20.04 | 16:00 |
| cachio_ | I am creating vms | 16:00 |
| cachio_ | I'll check the network configuration when vms are ready | 16:00 |
| ijohnson | thanks cachio | 16:06 |
| ijohnson | yeah I think the bug only effects uc20, I don't know that I've seen the netplan failure on uc16 or uc18 | 16:06 |
| ijohnson | mvo: pedronis: https://github.com/snapcore/snapd/pull/10133 is ready for review again | 16:16 |
| mup | PR #10133: wrappers/services.go: introduce EnsureSnapServices() <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10133> | 16:16 |
| ijohnson | mmm now our mac os tests are failing | 16:22 |
| ijohnson | homebew seems unhappy for some reason | 16:22 |
| ijohnson | *homebrew | 16:22 |
| cachio_ | ijohnson, https://paste.ubuntu.com/p/jVj7Nf4Pnx/ | 16:23 |
| cachio_ | ijohnson, so it has a mac address} | 16:24 |
| ijohnson | cachio_: right that makes sense, so probably not the same bug unfortunately | 16:46 |
| cachio_ | mvo, hey, about the test tests/core/gadget-kernel-refs-update-pc/task.yaml | 17:01 |
| cachio_ | does it make sense to run it on arm right? | 17:01 |
| cachio_ | because the kernel snap is harcoded to pc-kernel | 17:02 |
| === ijohnson is now known as ijohnson|lunch | ||
| mvo | cachio_: yeah, should not run on the arm machines | 17:43 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!