| mborzecki | morning | 05:26 |
|---|---|---|
| jamesh | mborzecki: are you able to restart the failed sub-job in https://travis-ci.org/snapcore/snapd/builds/562037700 ? | 05:57 |
| mborzecki | jamesh: sure, let me check | 06:01 |
| jamesh | thank you | 06:01 |
| mborzecki | jamesh: ok, restarted | 06:02 |
| zyga | Hello | 06:22 |
| mborzecki | zyga: hey | 06:34 |
| zyga | I will be around in 30 | 06:45 |
| mborzecki | need to run a quick errand | 06:55 |
| mborzecki | mvo: morning | 06:55 |
| mborzecki | zyga: mvo: i'm updating the notes on cgroups https://gist.github.com/bboozzoo/76b1535c93686a27bb7fdbaad0f560f7 and testing some things along the way | 06:55 |
| mborzecki | back in 30 or so | 06:55 |
| mvo | hey mborzecki | 07:02 |
| mvo | mborzecki: nice, thank you! | 07:02 |
| zyga | back now | 07:11 |
| zyga | mborzecki: looking | 07:11 |
| zyga | mvo: some good progress last week, apart from me forgetting to modify data sets for ubuntu core the new mount ns test is good | 07:12 |
| mup | PR snapd#7139 closed: tests: don't leak /run/netns mount <Simple 😃> <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7139> | 07:13 |
| zyga | mborzecki: I have answers to some of the TODOs there | 07:13 |
| mup | PR snapd#7127 closed: tests: removing support for ubuntu cosmic on spread test suite <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7127> | 07:18 |
| === JanC_ is now known as JanC | ||
| * zyga breakfast | 07:24 | |
| zyga | mborzecki: do you think my explanation on https://github.com/snapcore/snapd/pull/7138 makes sense? | 07:53 |
| mup | PR #7138: tests: remove lxd / lxcfs if pre-installed <Created by zyga> <https://github.com/snapcore/snapd/pull/7138> | 07:53 |
| mborzecki | re | 08:03 |
| mup | PR snapd#7138 closed: tests: remove lxd / lxcfs if pre-installed <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7138> | 08:28 |
| mvo | mup is back! | 08:29 |
| mvo | woooooh! | 08:29 |
| Chipaca | pedronis: WDYT of returning an ad-hoc struct from GetCurrentBlah? | 08:33 |
| pedronis | Chipaca: it's fine, adding Revision to PlaceInfo wouldn't be a bad idea | 08:34 |
| pedronis | but is a chunk of work because Info.Revision exists | 08:34 |
| Chipaca | pedronis: yeah, i'd need to hunt down all those first, but it's easy to do :-) | 08:35 |
| Chipaca | pedronis: should I park this, do the revision thing, and then do this? | 08:35 |
| Chipaca | i could timebox it to ~1h | 08:35 |
| jamesh | zyga: did you have any more comments on https://github.com/snapcore/snapd/pull/6959 (adding osutil.EnsureTreeState) after the last round of changes? | 08:37 |
| mup | PR #6959: osutil: add EnsureTreeState helper <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/6959> | 08:37 |
| pedronis | Chipaca: let's start with a simple struct | 08:37 |
| pedronis | and consider the other issue separately | 08:37 |
| mup | PR snapd#7141 closed: tests: add mountinfo-tool --ref-x1000 <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7141> | 08:38 |
| zyga | jamesh: I'll review it now | 08:38 |
| jamesh | zyga: thanks! | 08:38 |
| Chipaca | pedronis: ack | 08:38 |
| jamesh | zyga: I think everything is ready to land for https://github.com/snapcore/snapd/pull/7054 too | 08:39 |
| mup | PR #7054: interfaces: add an interface that grants access to the PackageKit service <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/7054> | 08:39 |
| zyga | jamesh: I'll check it out as well | 08:39 |
| zyga | ah, I remember it :) | 08:39 |
| Chipaca | pedronis: a single struct with kernel and core names and revisions, or two structs each with just naem and revision? | 08:47 |
| * Chipaca is full of silly questions today | 08:47 | |
| Chipaca | pedronis: i think two structs works better in this case | 08:47 |
| Chipaca | pedronis: but I don't know how you expect this to grow, yet | 08:47 |
| ackk | hi, is there a way to strace a program manually run inside a "snap run --shell" session ? | 08:49 |
| pedronis | Chipaca: sorry, I still think this should take snap.Type | 08:50 |
| Chipaca | :-( | 08:50 |
| pedronis | (it's the thing we need anyway going forward) | 08:50 |
| Chipaca | so much work done n times | 08:50 |
| Chipaca | but, ok | 08:50 |
| Chipaca | also it becomes a bunch of ifs again which is ugly | 08:51 |
| Chipaca | augh | 08:51 |
| pedronis | Chipaca: ? | 08:51 |
| Chipaca | pedronis: if type is kernel look for snap_kernel if type is core or base or os look for snap_core | 08:52 |
| pedronis | Chipaca: you understand that the one in booted goes way | 08:52 |
| pedronis | then, though | 08:52 |
| pedronis | that one has an if/switch anyway | 08:52 |
| Chipaca | ah, good point | 08:52 |
| pedronis | sorry, I thought this through but wasn't explicit | 08:53 |
| Chipaca | pedronis: booted has two calls to this though, and one of them will be calling this twice | 08:53 |
| pedronis | yes | 08:53 |
| pedronis | I know | 08:53 |
| Chipaca | ok | 08:53 |
| pedronis | that was my comment about efficient | 08:53 |
| Chipaca | on it | 08:53 |
| Chipaca | yeah, i figured | 08:53 |
| pedronis | but we'll need to change that anyway | 08:53 |
| pedronis | because at some point base and kernel info will be in two different places | 08:53 |
| pedronis | so something has to give | 08:53 |
| Chipaca | pedronis: a problem(ish, maybe more so in the future) with making it take type is that UpdateBootRevisions would, on the surface, need to know whether to use base or core | 09:04 |
| Chipaca | right now it makes no difference and I'll just use TypeOS | 09:04 |
| Chipaca | but core20 might make that harder | 09:05 |
| pedronis | Chipaca: I expect all this code to change again | 09:05 |
| Chipaca | "Ave, Haxor, morituri te salutant" | 09:06 |
| pedronis | Chipaca: I would use TypeBase thoug, no? and have a comment where used | 09:06 |
| Chipaca | pedronis: the result is the same either way -- why Base and not OS? | 09:06 |
| pedronis | Chipaca: because OS is "legacy" (dreaded word) | 09:07 |
| Chipaca | :-) | 09:07 |
| * Chipaca does «legacy, err := boot.GetCurrentBoot(snap.TypeOS)» | 09:07 | |
| Chipaca | pedronis: base it is then | 09:07 |
| Chipaca | pedronis: type NameAndRevno, or type NameAndRevision? | 09:11 |
| mup | PR snapd#7140 closed: overlord/devicestate: update gadget update handlers and mocks <Gadget update> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7140> | 09:11 |
| popey_ | jwheare: is 0.13.0 based off an internal branch? | 09:15 |
| jwheare | it's master | 09:15 |
| jwheare | hence edge channel | 09:15 |
| popey_ | ahh okay | 09:16 |
| popey_ | we'll start the machinery to create a pr for irccloud-desktop to put a face-punching dialog in it later | 09:16 |
| popey_ | in preparation | 09:16 |
| tomwardill | yay, irccloud and snaps <3 | 09:17 |
| * tomwardill switched | 09:19 | |
| === alan_g_ is now known as alan_g | ||
| pedronis | Chipaca: NameAndRevision | 09:38 |
| Chipaca | hmm, i've had to add boot vars to one of the manager tests for it to pass | 09:40 |
| Chipaca | something's leaking :-| | 09:40 |
| Chipaca | should probably add ad-hoc methods to MockBootloader to set these things instead of raw boot vars | 09:40 |
| pedronis | Chipaca: mmh, probably slightly better to have a function that takes a MockBootloader instead of a method | 09:45 |
| pedronis | we might have many mock bootloaders laters | 09:45 |
| pedronis | maybe | 09:45 |
| pedronis | or something else | 09:45 |
| pedronis | Chipaca: boottest.SetBoot(bootloader,...) or something | 09:46 |
| Chipaca | pedronis: boottest.SetBootKernel(kernel, bootloader...)? | 09:47 |
| Chipaca | wth why does seahorse suddenly refuse to see my gpg keys | 09:48 |
| Chipaca | i'm going to have to edit the expiration on the terminal, like a caveman | 09:48 |
| pedronis | Chipaca: that works though, and SetBootBase ? | 09:48 |
| pedronis | doesn't need to take many for now | 09:48 |
| pedronis | I mean many bootloaders | 09:48 |
| Chipaca | pedronis: and SetBootMode maybe | 09:49 |
| Chipaca | i'll look to see how much that one is set outside of boot itself | 09:49 |
| Chipaca | first need to sort out my gpg keys as they've _just_ expired :) | 09:49 |
| mup | PR snapd#7054 closed: interfaces: add an interface that grants access to the PackageKit service <Created by jhenstridge> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7054> | 09:50 |
| jwheare | popey_: 0.13.0 has now been released, but the snap will continue to be edge channel due to the config perms crash | 09:59 |
| mvo | pedronis 7132 has a small suggestion and needs a test fix - if you agree with the ideas in there I could do it before lunch if you are busy | 10:04 |
| pedronis | mvo: given you have the changes, yes please, then it can be merged, right? if/when green | 10:06 |
| pedronis | *changes already | 10:07 |
| mvo | pedronis: I have the unroll, I need to fix one test failure that the PR has right now but hopefully easy | 10:12 |
| pedronis | mvo: something is missing to call StartUp I suppose | 10:18 |
| mvo | pedronis: yeah, happy to poke at it, just don't want to duplicate work :) | 10:19 |
| mvo | (i.e. want to ensure I don't look at this if you also do or know what to do etc) | 10:19 |
| pedronis | mvo: it's a one line fix | 10:22 |
| pedronis | mvo: this is likely the safest (going forward) fix: https://pastebin.ubuntu.com/p/bbg7hzqyyW/ | 10:23 |
| Chipaca | pedronis: I didn't add a SetBootMode one because the tests that are setting that seem to be caring about the mechanics of the whole update/rollback via boot things, so it'd be a rather bigger refactor | 10:26 |
| pedronis | that's fine | 10:26 |
| Chipaca | ie they set boot_mode and also snap_try_core | 10:26 |
| Chipaca | er, snap_mode* | 10:27 |
| Chipaca | probably worthwhile doing at some point, but not as part of this :) | 10:27 |
| mvo | pedronis: \o/ | 10:27 |
| pedronis | Chipaca: +1, with some cosmetic nitpicks | 10:33 |
| Chipaca | pedronis: thanks | 10:34 |
| pedronis | probably need a 2nd look from mvo again | 10:34 |
| pedronis | given it changed quite a bit | 10:34 |
| jamesh | pedronis: re. your comments on https://github.com/snapcore/snapd/pull/6954, is designing a new REST API a blocker for the PR, or could that be delayed to a later PR (but before new API methods that actually do something are added)? | 10:36 |
| mup | PR #6954: sessionagent: add a REST interface with socket activation <Needs Samuele review> <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/6954> | 10:36 |
| Chipaca | mvo: requested a re-review on #7142 as it's changed quite a bit | 10:54 |
| mup | PR #7142: boot, o/snapst, o/devicest: limit knowledge of boot vars to boot <Created by chipaca> <https://github.com/snapcore/snapd/pull/7142> | 10:54 |
| pedronis | jamesh: I plan to tweak it (slightly) and land it myself at this point, either today or tomorrow | 10:58 |
| jamesh | pedronis: okay. Thanks! | 10:58 |
| mvo | Chipaca: sure, will do | 10:59 |
| pedronis | jamesh: also, I made a small comment and asked a question in the EnsureTreeState one, it seems super close | 11:06 |
| pedronis | mvo: Chipaca: I'm going to merge 6923 (I undid the renaming because I used cstrs all over the place, so if we want a better spelling we should change it across separately) | 11:25 |
| mup | PR snapd#6923 closed: interfaces/policy: minimal policy check for replacing sanitizeReservedFor... helpers (1/2) <Complex> <Created by stolowski> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/6923> | 11:27 |
| Chipaca | pedronis: ¯\_(ツ)_/¯ | 11:28 |
| pedronis | Chipaca: I don't have a strong preference, I think I choose the horrible names because some lines were very long but oh well | 11:29 |
| jwheare | jamesh: any thoughts on next steps for 7129? | 11:29 |
| mborzecki | mvo: one of our dependencies, github.com/ojii/gettext.go is no longer available in fedora | 11:30 |
| mborzecki | mvo: also they're using gopkg.in/cheggaaa/pb.v1 rather than github.com/cheggaaa/pb now | 11:31 |
| mup | PR snapd#7121 closed: tests: part2 making tests work on ubuntu-core-18 <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/7121> | 11:34 |
| jwheare | mup ignored me https://github.com/snapcore/snapd/pull/7129 | 11:40 |
| mup | PR #7129: userd: allow setting default-url-scheme-handler <Created by jwheare> <https://github.com/snapcore/snapd/pull/7129> | 11:40 |
| zyga | mvo: https://github.com/snapcore/snapd/pull/7091 is green :) | 11:47 |
| mup | PR #7091: tests: measure properties of various mount namespaces <Created by zyga> <https://github.com/snapcore/snapd/pull/7091> | 11:47 |
| zyga | mborzecki: can you have a 2nd look on the test | 11:47 |
| zyga | mborzecki: I tweaked it a little | 11:47 |
| zyga | mborzecki: I will adjust the wording, though ideally in a follow up since this took a while to get to | 11:47 |
| * zyga lunch | 11:53 | |
| pedronis | is the hyper-v image still broken: https://forum.snapcraft.io/t/error-too-early-for-operation-device-not-yet-seeded-or-device-model-not-acknowledged/12421 ? | 12:16 |
| mup | PR # closed: snapd#5644, snapd#5822, snapd#6108, snapd#6258, snapd#6341, snapd#6347, snapd#6360, snapd#6367, snapd#6404, snapd#6436, snapd#6666, snapd#6697, snapd#6705, snapd#6708, snapd#6714, snapd#6767, snapd#6839, snapd#6891, snapd#6950, snapd#6954, snapd#6959, snapd#6972, snapd#7005, | 12:20 |
| mup | snapd#7010, snapd#7031, snapd#7042, snapd#7066, snapd#7067, snapd#7073, snapd#7074, snapd#7079, snapd#7081, snapd#7087, snapd#7088, snapd#7091, snapd#7092, snapd#7109, snapd#7110, snapd#7111, snapd#7112, snapd#7124, snapd#7125, snapd#7126, snapd#7128, snapd#7129, snapd#7130, snapd#7131, snapd#7132, | 12:20 |
| mup | snapd#7133, snapd#7135, snapd#7136, snapd#7137, snapd#7142 | 12:20 |
| mup | PR # opened: snapd#5644, snapd#5822, snapd#6108, snapd#6258, snapd#6341, snapd#6347, snapd#6360, snapd#6367, snapd#6404, snapd#6436, snapd#6666, snapd#6697, snapd#6705, snapd#6708, snapd#6714, snapd#6767, snapd#6839, snapd#6891, snapd#6950, snapd#6954, snapd#6959, snapd#6972, snapd#7005, | 12:21 |
| mup | snapd#7010, snapd#7031, snapd#7042, snapd#7066, snapd#7067, snapd#7073, snapd#7074, snapd#7079, snapd#7081, snapd#7087, snapd#7088, snapd#7091, snapd#7092, snapd#7109, snapd#7110, snapd#7111, snapd#7112, snapd#7124, snapd#7125, snapd#7126, snapd#7128, snapd#7129, snapd#7130, snapd#7131, snapd#7132, | 12:21 |
| mup | snapd#7133, snapd#7135, snapd#7136, snapd#7137, snapd#7142, snapd#7143 | 12:21 |
| zyga | pedronis: I can check | 12:29 |
| zyga | pedronis: I have my windows hyper-v laptop | 12:29 |
| zyga | pedronis: there are two images available in the windows gallery: 19.04 and 18.04.2 | 12:38 |
| zyga | I'll create each and let you know | 12:38 |
| mup | PR snapd#7091 closed: tests: measure properties of various mount namespaces <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7091> | 12:51 |
| mup | PR snapd#7144 opened: tests: measure mount namespaces on Ubuntu 14.04 <Created by zyga> <https://github.com/snapcore/snapd/pull/7144> | 12:54 |
| mup | PR snapd#6959 closed: osutil: add EnsureTreeState helper <Created by jhenstridge> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6959> | 13:11 |
| ogra | Chipaca, i assume hello and hello-world havent been updated to base: core18 ? | 13:16 |
| Chipaca | ogra: correct | 13:17 |
| Chipaca | ogra: snap info tells you as much i think | 13:17 |
| ogra | right, then i guess my assumption is correct too | 13:17 |
| ogra | (and the tutorial needs fixing) | 13:17 |
| Chipaca | ogra: which is your assumption? | 13:17 |
| ogra | snapd wont start because the core snap doesnt exist but the hello snap is a required snap | 13:18 |
| ogra | so seeding cant complete | 13:18 |
| ogra | since a UC18 image only has core18 ... obviously | 13:18 |
| jdstrand | pedronis: fyi, I responded to https://forum.snapcraft.io/t/netplan-apply-inside-snaps/12411 (little surprised I wasn't invited to participate, but that's ok so long as the discussion continues in the forum) | 13:22 |
| pedronis | jdstrand: sorry, I thought about maybe to invite but was a last minute meeting | 13:23 |
| pedronis | jdstrand: also today we need to talk with foundation about the plan | 13:24 |
| mup | PR snapd#7145 opened: packaging/fedora: github.com/cheggaaa/pb is no longer used <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7145> | 13:24 |
| jdstrand | pedronis, mvo: also, fyi, https://github.com/snapcore/snapd/pull/7111, https://github.com/snapcore/snapd/pull/7112 and https://github.com/snapcore/snapd/pull/7124 should be ready for review (there is one small thing I want to do in a subsequent PR, but it isn't required) | 13:24 |
| mup | PR #7111: many: support system-usernames for 'snap_daemon' user <Created by jdstrand> <https://github.com/snapcore/snapd/pull/7111> | 13:24 |
| mup | PR #7112: many: allow 'system-usernames' with libseccomp > 2.4 and golang-seccomp > 0.9.0 <Created by jdstrand> <https://github.com/snapcore/snapd/pull/7112> | 13:24 |
| mup | PR #7124: many: create system-usernames user/group if both don't exist <Created by jdstrand> <https://github.com/snapcore/snapd/pull/7124> | 13:24 |
| jdstrand | pedronis: no worries | 13:24 |
| jdstrand | I've unblocked all of them and marked for 2.441 | 13:25 |
| jdstrand | 2.41 | 13:25 |
| * jdstrand also has docs to write and forum posts to update | 13:26 | |
| Chipaca | 2.44.1.441.14 | 13:26 |
| jdstrand | hehe | 13:26 |
| jdstrand | pedronis: oh, and I | 13:28 |
| jdstrand | 'm mashing 'Restart' for PR 7124's tests (normal intermittent non-PR related failures) | 13:28 |
| mup | PR #7124: many: create system-usernames user/group if both don't exist <Created by jdstrand> <https://github.com/snapcore/snapd/pull/7124> | 13:29 |
| jdstrand | the other two have passed | 13:29 |
| Chipaca | mvo: https://knowyourmeme.com/memes/naruto-run | 13:30 |
| mvo | Chipaca: ta | 13:31 |
| Chipaca | mvo: can't have our manager falling that far behind | 13:32 |
| mup | PR snapd#7146 opened: UC20: cmd/snap-verify: sketch of snap-verify <Created by pedronis> <https://github.com/snapcore/snapd/pull/7146> | 14:08 |
| * cachio AFK | 14:11 | |
| mup | PR core-build#47 closed: initramfs: restore wait-for-root calls <Created by cmatsuoka> <Merged by mvo5> <https://github.com/snapcore/core-build/pull/47> | 14:23 |
| ackk | jdstrand, hi, did you by chance manage to reproduce the issue with systemd-detect-virt not working in a VM? | 14:40 |
| Chipaca | ackk: in which vm? | 14:50 |
| Chipaca | ackk: and not working how? | 14:50 |
| ackk | Chipaca, https://bugs.launchpad.net/snapd/+bug/1831473 | 14:51 |
| ackk | (recent comments) | 14:51 |
| mup | Bug #1831473: Can't run /usr/bin/systemd-detect-virt from inside snap <maas> <snapd:New for jdstrand> <https://launchpad.net/bugs/1831473> | 14:51 |
| Chipaca | ackk: ah ok | 14:51 |
| Chipaca | ackk: for a moment i thought maybe it had something to do with systemd-detect-virt using capabilities instead of setuid | 14:52 |
| ackk | Chipaca, it doesn't seems not being able to read /proc/1/sched is really an issue (I did mention it since I was getting a denial there) | 14:53 |
| Chipaca | ackk: I blame mvo | 15:05 |
| ogra | he's so easy to blame | 15:07 |
| cwayne | ogra: not as easy as ondra though | 15:15 |
| ogra | true dat .... | 15:16 |
| mvo | Chipaca: wuut? | 15:22 |
| ijohnson | cwayne: don't you mean ondras | 15:29 |
| cwayne | I refuse to believe there's more than one | 15:29 |
| ogra | since people recently start mixing up ogra and ondra all the time in pings i guess he just wants to be more than me now :P | 15:42 |
| ackk | Chipaca, so you know what's going wrong, or just generically blaming mvo? :) | 15:55 |
| Chipaca | ackk: just generically | 15:57 |
| ackk | heh | 15:57 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!