pedronismborzecki: hi, I would appreciate reviews for #8907 and #898406:39
mupPR #8907: asserts: implement Database.FindSequence <validation-sets :white_check_mark:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/8907>06:39
mupPR #8984: asserts: integer headers: disallow prefix zeros and make parsing more uniform <validation-sets :white_check_mark:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/8984>06:39
mborzeckipedronis: hi, will do06:40
mborzeckimvo: pedronis: sent out the tiny spec for uc20 recovery on rpi, please take a look07:11
mborzeckipedronis: mvo: i'll write down something similar about grub.cfg command line and share it with you guys07:12
pedronismborzecki: ok, I'll see when I can look at it07:15
pedronispstolowski: hi, #8907 needs a review, I also made #898407:15
mupPR #8907: asserts: implement Database.FindSequence <validation-sets :white_check_mark:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/8907>07:15
mupPR #8984: asserts: integer headers: disallow prefix zeros and make parsing more uniform <validation-sets :white_check_mark:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/8984>07:15
pstolowskipedronis: hi, will review today07:16
mvomborzecki: thank you07:19
=== pedronis_ is now known as pedronis
zygagood morning07:51
zygasorry for starting late, I woke up very early due to pain and then tired to sleep again after taking painkillers07:52
mupPR core18#159 closed: 030-fix-timedatectl.chroot: fix quoting issues <Created by mvo5> <Merged by sil2100> <https://github.com/snapcore/core18/pull/159>08:41
zygadrat, lucy just walked over the keyboard and sigquit spread09:31
pstolowskizyga: haha09:52
zygawhat are the chances...09:54
* zyga is debugging some weird failures09:57
zygamborzecki: something weird is going on in feature/track-launched-apps on tumbleweed10:06
zygaon master that test passes10:07
zygaon the feature branch it fails10:07
zygaas if making the transient scope actually affected the existing tracking using the pid cgroup10:07
zygabut why only on tumbleweed?10:07
* zyga investigates10:07
zygamaybe they moved to cgroupv2?10:08
zyganotably the test does not fail in the big branch where we use the new information for the same decision10:08
zygaso maybe ...?10:08
zygaand now it passes10:25
zygawhat the heck?!10:25
* zyga thinks and tries to drink coffee10:26
mborzeckiok, docs updated, now onto the reviews10:34
* sdhd-sascha Ooh, too much beer yesterday10:35
zygamborzecki: thanks10:36
mborzeckizyga:  can you review https://github.com/snapcore/snapd/pull/8883 ?11:01
mupPR #8883: packaging: stop snapd early on purge <Test Robustness> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8883>11:01
zygamborzecki: after the call11:07
zygamborzecki: https://github.com/snapcore/snapd/pull/8883/checks?check_run_id=845292346 fails11:22
mupPR #8883: packaging: stop snapd early on purge <Test Robustness> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8883>11:22
mborzeckiuh, 14.4011:23
mborzeckipff fun11:23
zygamborzecki: ping me when ready12:02
zygaI'm debugging something related to old tracking12:02
ijohnson|sprintmborzecki: took a real quick look at your doc12:03
mborzeckiijohnson|sprint: hey, thanks12:13
zygaeh, I add logging and now it passes12:31
zygathere must be something racy there12:31
zygaall right, it failed now12:32
zygaahh, I have a feeling I know what's wrong12:34
zygamborzecki: heh, start transient scope keeps on giving12:57
* zyga thinks12:57
zygathinks it's time to join the call12:58
mborzeckiheh ;)12:58
mupPR snapd#8986 opened: tests: new snaps-state command - part1 <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8986>13:03
ijohnson|sprintzyga: I managed to fix my layout verification PR, it was as expected to use Layout.Path instead of the key in the map13:13
mvoondra: hey, I played with the latest go which has some linker improvements - the snap-bootstrap binary is down from 11mb stripped to 7.7mb stripped. so low mem snapd looks more feasible13:42
* zyga break for meds and some rest13:59
* cachio lunch15:37
pstolowskicachio: +1 for your 'run nested' pr, please ping someone for 2nd review15:55
cachioPsi-Jack, thanks16:38
ograjust take the credit, don't complain ...16:55
cachioPsi-Jack, sorry, was pstolowski but he quited16:55
cachioPsi-Jack, I think it is the seconds time I do the same16:56
* zyga tested 16.04 and 18.04 and systemd is not racy there17:16
zygatrying 20.04 and adding workaround in software on our side17:16
zyga20.04 also passes, trying 20.10 which should be close to sid17:28
zygabut this suggests either a regression in systemd17:28
zygaor a "feature"17:28
zyga20.10 testing now..17:44
zygaamd it seems to pass17:44
zygamaybe we have patches in systemd17:44
zygajdstrand: ^ more tracking mystery17:44
zygagoing to test debian-9 vs sid17:47
sdhd-saschahey people, i really regret my level of alcohol, yesterday ;-) sorry ;-)17:53
ograit was rather obvious 🙂17:54
sdhd-saschaogra: thank you ;-) i try to go another way in future ;-)17:57
sdhd-saschadid anybody mention the birds, and there song's? here in bavaria, they decrease volume. Then after lockdown they increase there songs... And now, they have learn both ;-)18:01
zygahmm, debian, even sid does not fail, so it is really just tumbleweed or was my sample size too small18:08
mupPR snapd#8907 closed: asserts: implement Database.FindSequence <validation-sets :white_check_mark:> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/8907>18:09
sdhd-saschaogra: i share your love for graph-algos . But didn't have a hint how to optimize it?!18:09
cachiozyga, hi18:10
zygacachio: hi18:11
cachioI was checking and to run shellcheck on tools tests we need to install the shellcheck snap18:11
cachiobut for that we need to have the snap command available18:11
cachiozyga, does it make sense?18:11
zygacachio: yes, I ran into this myself, it's not fortunate but perhaps unavoidable18:12
cachiozyga, currently we prepare the suite with --prepare-suite-each-minimal-no-snaps18:12
zygacachio: alternatively, don't install it18:12
zygacachio: but install it only on one system18:12
zygacachio: and run shellcheck e.g. only on ubuntu 20.0418:12
zygathis way we test on more systems18:12
zygaand shellcheck at least once18:12
zyganote that that suite does not have full snapd ready18:12
zygaso it may not be possible to install snaps18:13
cachiobut then we also need to have snap to test the snaps tool that I just created18:13
sdhd-saschaooh, just a "deb" problem ? or others have that too?18:13
cachiozyga, but for that I could install snapd and then purge18:13
zygacachio: hmmm18:14
zygacachio: perhaps the snap helper needs different strategy18:14
zygacachio: for generic helpers I would not install snapd18:14
zygacachio: perhaps the snap helper needs to live in main18:14
zyga(as in tests)18:14
mupPR snapd#8984 closed: asserts: integer headers: disallow prefix zeros and make parsing more uniform <validation-sets :white_check_mark:> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/8984>18:14
cachiozyga, you need the test18:14
sdhd-saschacachio: i love purge... But there was a AI, which should sort a list. The AI has won, with purging the complete list ;-)18:14
cachiozyga, so I'll move the test to main in that case18:15
zygacachio: I think that's better18:15
cachiozyga, good18:15
zygawhat's the name of the tool btw?18:16
ograschnaps-state ...18:18
cachiozyga, but it could change18:18
zygacachio: do you want it to be on PATH?18:18
zygacachio: note that the naming rules differ between the two18:18
cachiozyga, no18:18
cachiojust to be on path when we debug18:18
zygahow would that work?18:18
cachioI'll use it like $TESTSTOOLS"/snap-state18:19
cachioso it should be fine18:19
zygaI see18:19
zygaif you want it on path it could be called tests.snap or something like that18:20
zygaI think that's okay too18:20
zygano strong opinion either way18:20
cachiook, so far it is ok18:24
cachiohaving this "$TESTSTOOLS"/snap-state is it ok18:24
cachiozyga, also we could have a test targeted to ubuntu-18.04 which runs shellcheck for all the bash files in tools18:30
zygacachio: I think we kind of do that already (perhaps) via run-checks but yeah18:31
zygabut I really prefer each tool test to check itself18:31
zygathen it's obvious18:31
sdhd-saschazyga: cachio: hey, at high-level language, it's possible to write once, and work everywhere ;-)18:31
* sdhd-sascha short afk18:33
mupPR snapcraft#3205 opened: spread tests: higher timeout for extension tests <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3205>18:56

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!