jameshmborzecki: are you able to restart the failed sub-job in https://travis-ci.org/snapcore/snapd/builds/562037700 ?05:57
mborzeckijamesh: sure, let me check06:01
jameshthank you06:01
mborzeckijamesh: ok, restarted06:02
mborzeckizyga: hey06:34
zygaI will be around in 3006:45
mborzeckineed to run a quick errand06:55
mborzeckimvo: morning06:55
mborzeckizyga: mvo: i'm updating the notes on cgroups https://gist.github.com/bboozzoo/76b1535c93686a27bb7fdbaad0f560f7 and testing some things along the way06:55
mborzeckiback in 30 or so06:55
mvohey mborzecki07:02
mvomborzecki: nice, thank you!07:02
zygaback now07:11
zygamborzecki: looking07:11
zygamvo: some good progress last week, apart from me forgetting to modify data sets for ubuntu core the new mount ns test is good07:12
mupPR snapd#7139 closed: tests: don't leak /run/netns mount <Simple 😃> <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7139>07:13
zygamborzecki: I have answers to some of the TODOs there07:13
mupPR snapd#7127 closed: tests: removing support for ubuntu cosmic on spread test suite <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7127>07:18
=== JanC_ is now known as JanC
* zyga breakfast07:24
zygamborzecki: do you think my explanation on https://github.com/snapcore/snapd/pull/7138 makes sense?07:53
mupPR #7138: tests: remove lxd / lxcfs if pre-installed <Created by zyga> <https://github.com/snapcore/snapd/pull/7138>07:53
mupPR snapd#7138 closed: tests: remove lxd / lxcfs if pre-installed <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7138>08:28
mvomup is back!08:29
Chipacapedronis: WDYT of returning an ad-hoc struct from GetCurrentBlah?08:33
pedronisChipaca: it's fine,  adding Revision to PlaceInfo wouldn't be a bad idea08:34
pedronisbut is a chunk of work because Info.Revision exists08:34
Chipacapedronis: yeah, i'd need to hunt down all those first, but it's easy to do :-)08:35
Chipacapedronis: should I park this, do the revision thing, and then do this?08:35
Chipacai could timebox it to ~1h08:35
jameshzyga: did you have any more comments on https://github.com/snapcore/snapd/pull/6959 (adding osutil.EnsureTreeState) after the last round of changes?08:37
mupPR #6959: osutil: add EnsureTreeState helper <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/6959>08:37
pedronisChipaca: let's start with a simple struct08:37
pedronisand consider the other issue separately08:37
mupPR snapd#7141 closed: tests: add mountinfo-tool --ref-x1000 <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7141>08:38
zygajamesh: I'll review it now08:38
jameshzyga: thanks!08:38
Chipacapedronis: ack08:38
jameshzyga: I think everything is ready to land for https://github.com/snapcore/snapd/pull/7054 too08:39
mupPR #7054: interfaces: add an interface that grants access to the PackageKit service <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/7054>08:39
zygajamesh: I'll check it out as well08:39
zygaah, I remember it :)08:39
Chipacapedronis: a single struct with kernel and core names and revisions, or two structs each with just naem and revision?08:47
* Chipaca is full of silly questions today08:47
Chipacapedronis: i think two structs works better in this case08:47
Chipacapedronis: but I don't know how you expect this to grow, yet08:47
ackkhi, is there a way to strace a program manually run inside a "snap run --shell" session ?08:49
pedronisChipaca: sorry, I still think this should take snap.Type08:50
pedronis(it's the thing we need anyway going forward)08:50
Chipacaso much work done n times08:50
Chipacabut, ok08:50
Chipacaalso it becomes a bunch of ifs again which is ugly08:51
pedronisChipaca: ?08:51
Chipacapedronis: if type is kernel look for snap_kernel if type is core or base or os look for snap_core08:52
pedronisChipaca: you understand that the one in booted goes way08:52
pedronisthen, though08:52
pedronisthat one has an if/switch anyway08:52
Chipacaah, good point08:52
pedronissorry, I thought this through but wasn't explicit08:53
Chipacapedronis: booted has two calls to this though, and one of them will be calling this twice08:53
pedronisI know08:53
pedronisthat was my comment about efficient08:53
Chipacaon it08:53
Chipacayeah, i figured08:53
pedronisbut we'll need to change that anyway08:53
pedronisbecause at some point base and kernel info will be in two different places08:53
pedronisso something has to give08:53
Chipacapedronis: a problem(ish, maybe more so in the future) with making it take type is that UpdateBootRevisions would, on the surface, need to know whether to use base or core09:04
Chipacaright now it makes no difference and I'll just use TypeOS09:04
Chipacabut core20 might make that harder09:05
pedronisChipaca: I expect all this code to change again09:05
Chipaca"Ave, Haxor, morituri te salutant"09:06
pedronisChipaca: I would use TypeBase thoug, no?  and have a comment where used09:06
Chipacapedronis: the result is the same either way -- why Base and not OS?09:06
pedronisChipaca: because OS is "legacy" (dreaded word)09:07
* Chipaca does «legacy, err := boot.GetCurrentBoot(snap.TypeOS)»09:07
Chipacapedronis: base it is then09:07
Chipacapedronis: type NameAndRevno, or type NameAndRevision?09:11
mupPR snapd#7140 closed: overlord/devicestate: update gadget update handlers and mocks <Gadget update> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7140>09:11
popey_jwheare: is 0.13.0 based off an internal branch?09:15
jwheareit's master09:15
jwhearehence edge channel09:15
popey_ahh okay09:16
popey_we'll start the machinery to create a pr for irccloud-desktop to put a face-punching dialog in it later09:16
popey_in preparation09:16
tomwardillyay, irccloud and snaps <309:17
* tomwardill switched09:19
=== alan_g_ is now known as alan_g
pedronisChipaca: NameAndRevision09:38
Chipacahmm, i've had to add boot vars to one of the manager tests for it to pass09:40
Chipacasomething's leaking :-|09:40
Chipacashould probably add ad-hoc methods to MockBootloader to set these things instead of raw boot vars09:40
pedronisChipaca: mmh, probably slightly better to have a function that takes a MockBootloader instead of a method09:45
pedroniswe might have many mock bootloaders laters09:45
pedronisor something else09:45
pedronisChipaca: boottest.SetBoot(bootloader,...) or something09:46
Chipacapedronis: boottest.SetBootKernel(kernel, bootloader...)?09:47
Chipacawth why does seahorse suddenly refuse to see my gpg keys09:48
Chipacai'm going to have to edit the expiration on the terminal, like a caveman09:48
pedronisChipaca: that works though, and SetBootBase ?09:48
pedronisdoesn't need to take many for now09:48
pedronisI mean many bootloaders09:48
Chipacapedronis: and SetBootMode maybe09:49
Chipacai'll look to see how much that one is set outside of boot itself09:49
Chipacafirst need to sort out my gpg keys as they've _just_ expired :)09:49
mupPR snapd#7054 closed: interfaces: add an interface that grants access to the PackageKit service <Created by jhenstridge> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7054>09:50
jwhearepopey_: 0.13.0 has now been released, but the snap will continue to be edge channel due to the config perms crash09:59
mvopedronis 7132 has a small suggestion and needs a test fix - if you agree with the ideas in there I could do it before lunch if you are busy10:04
pedronismvo: given you have the changes, yes please, then it can be merged, right? if/when green10:06
pedronis*changes already10:07
mvopedronis: I have the unroll, I need to fix one test failure that the PR has right now but hopefully easy10:12
pedronismvo: something is missing to call StartUp I suppose10:18
mvopedronis: yeah, happy to poke at it, just don't want to duplicate work :)10:19
mvo(i.e. want to ensure I don't look at this if you also do or know what to do etc)10:19
pedronismvo: it's a one line fix10:22
pedronismvo: this is likely the safest (going forward) fix:  https://pastebin.ubuntu.com/p/bbg7hzqyyW/10:23
Chipacapedronis: I didn't add a SetBootMode one because the tests that are setting that seem to be caring about the mechanics of the whole update/rollback via boot things, so it'd be a rather bigger refactor10:26
pedronisthat's fine10:26
Chipacaie they set boot_mode and also snap_try_core10:26
Chipacaer, snap_mode*10:27
Chipacaprobably worthwhile doing at some point, but not as part of this :)10:27
mvopedronis: \o/10:27
pedronisChipaca: +1, with some cosmetic nitpicks10:33
Chipacapedronis: thanks10:34
pedronisprobably need a 2nd look from mvo again10:34
pedronisgiven it changed quite a bit10:34
jameshpedronis: re. your comments on https://github.com/snapcore/snapd/pull/6954, is designing a new REST API a blocker for the PR, or could that be delayed to a later PR (but before new API methods that actually do something are added)?10:36
mupPR #6954: sessionagent: add a REST interface with socket activation <Needs Samuele review> <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/6954>10:36
Chipacamvo: requested a re-review on #7142 as it's changed quite a bit10:54
mupPR #7142: boot, o/snapst, o/devicest: limit knowledge of boot vars to boot <Created by chipaca> <https://github.com/snapcore/snapd/pull/7142>10:54
pedronisjamesh: I plan to tweak it (slightly) and land it myself at this point, either today or tomorrow10:58
jameshpedronis: okay.  Thanks!10:58
mvoChipaca: sure, will do10:59
pedronisjamesh: also, I made a small comment and asked a question in the EnsureTreeState one, it seems super close11:06
pedronismvo: Chipaca: I'm going to merge 6923 (I undid the renaming because I used cstrs all over the place, so if we want a better spelling we should change it across separately)11:25
mupPR snapd#6923 closed: interfaces/policy: minimal policy check for replacing sanitizeReservedFor... helpers (1/2) <Complex> <Created by stolowski> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/6923>11:27
Chipacapedronis: ¯\_(ツ)_/¯11:28
pedronisChipaca: I don't have a strong preference, I think I choose the horrible names because some lines were very long but oh well11:29
jwhearejamesh: any thoughts on next steps for 7129?11:29
mborzeckimvo: one of our dependencies, github.com/ojii/gettext.go is no longer available in fedora11:30
mborzeckimvo: also they're using gopkg.in/cheggaaa/pb.v1 rather than github.com/cheggaaa/pb now11:31
mupPR snapd#7121 closed: tests: part2 making tests work on ubuntu-core-18 <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/7121>11:34
jwhearemup ignored me https://github.com/snapcore/snapd/pull/712911:40
mupPR #7129: userd: allow setting default-url-scheme-handler <Created by jwheare> <https://github.com/snapcore/snapd/pull/7129>11:40
zygamvo: https://github.com/snapcore/snapd/pull/7091 is green :)11:47
mupPR #7091: tests: measure properties of various  mount namespaces <Created by zyga> <https://github.com/snapcore/snapd/pull/7091>11:47
zygamborzecki: can you have a 2nd look on the test11:47
zygamborzecki: I tweaked it a little11:47
zygamborzecki: I will adjust the wording, though ideally in a follow up since this took a while to get to11:47
* zyga lunch11:53
pedronisis the hyper-v image still broken: https://forum.snapcraft.io/t/error-too-early-for-operation-device-not-yet-seeded-or-device-model-not-acknowledged/12421 ?12:16
mupPR # closed: snapd#5644, snapd#5822, snapd#6108, snapd#6258, snapd#6341, snapd#6347, snapd#6360, snapd#6367, snapd#6404, snapd#6436, snapd#6666, snapd#6697, snapd#6705, snapd#6708, snapd#6714, snapd#6767, snapd#6839, snapd#6891, snapd#6950, snapd#6954, snapd#6959, snapd#6972, snapd#7005,12:20
mupsnapd#7010, snapd#7031, snapd#7042, snapd#7066, snapd#7067, snapd#7073, snapd#7074, snapd#7079, snapd#7081, snapd#7087, snapd#7088, snapd#7091, snapd#7092, snapd#7109, snapd#7110, snapd#7111, snapd#7112, snapd#7124, snapd#7125, snapd#7126, snapd#7128, snapd#7129, snapd#7130, snapd#7131, snapd#7132,12:20
mupsnapd#7133, snapd#7135, snapd#7136, snapd#7137, snapd#714212:20
mupPR # opened: snapd#5644, snapd#5822, snapd#6108, snapd#6258, snapd#6341, snapd#6347, snapd#6360, snapd#6367, snapd#6404, snapd#6436, snapd#6666, snapd#6697, snapd#6705, snapd#6708, snapd#6714, snapd#6767, snapd#6839, snapd#6891, snapd#6950, snapd#6954, snapd#6959, snapd#6972, snapd#7005,12:21
mupsnapd#7010, snapd#7031, snapd#7042, snapd#7066, snapd#7067, snapd#7073, snapd#7074, snapd#7079, snapd#7081, snapd#7087, snapd#7088, snapd#7091, snapd#7092, snapd#7109, snapd#7110, snapd#7111, snapd#7112, snapd#7124, snapd#7125, snapd#7126, snapd#7128, snapd#7129, snapd#7130, snapd#7131, snapd#7132,12:21
mupsnapd#7133, snapd#7135, snapd#7136, snapd#7137, snapd#7142, snapd#714312:21
zygapedronis: I can check12:29
zygapedronis: I have my windows hyper-v laptop12:29
zygapedronis: there are two images available in the windows gallery: 19.04 and 18.04.212:38
zygaI'll create each and let you know12:38
mupPR snapd#7091 closed: tests: measure properties of various  mount namespaces <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7091>12:51
mupPR snapd#7144 opened: tests: measure mount namespaces on Ubuntu 14.04 <Created by zyga> <https://github.com/snapcore/snapd/pull/7144>12:54
mupPR snapd#6959 closed: osutil: add EnsureTreeState helper <Created by jhenstridge> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6959>13:11
ograChipaca, i assume hello and hello-world havent been updated to base: core18 ?13:16
Chipacaogra: correct13:17
Chipacaogra: snap info tells you as much i think13:17
ograright, then i guess my assumption is correct too13:17
ogra(and the tutorial needs fixing)13:17
Chipacaogra: which is your assumption?13:17
ograsnapd wont start because the core snap doesnt exist but the hello snap is a required snap13:18
ograso seeding cant complete13:18
ograsince a UC18 image only has core18 ... obviously13:18
jdstrandpedronis: fyi, I responded to https://forum.snapcraft.io/t/netplan-apply-inside-snaps/12411 (little surprised I wasn't invited to participate, but that's ok so long as the discussion continues in the forum)13:22
pedronisjdstrand: sorry, I thought about maybe to invite but was a last minute meeting13:23
pedronisjdstrand: also today we need to talk with foundation about the plan13:24
mupPR snapd#7145 opened: packaging/fedora: github.com/cheggaaa/pb is no longer used <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7145>13:24
jdstrandpedronis, mvo: also, fyi, https://github.com/snapcore/snapd/pull/7111, https://github.com/snapcore/snapd/pull/7112 and https://github.com/snapcore/snapd/pull/7124 should be ready for review (there is one small thing I want to do in a subsequent PR, but it isn't required)13:24
mupPR #7111: many: support system-usernames for 'snap_daemon' user <Created by jdstrand> <https://github.com/snapcore/snapd/pull/7111>13:24
mupPR #7112: many: allow 'system-usernames' with libseccomp > 2.4 and golang-seccomp > 0.9.0 <Created by jdstrand> <https://github.com/snapcore/snapd/pull/7112>13:24
mupPR #7124: many: create system-usernames user/group if both don't exist <Created by jdstrand> <https://github.com/snapcore/snapd/pull/7124>13:24
jdstrandpedronis: no worries13:24
jdstrandI've unblocked all of them and marked for 2.44113:25
* jdstrand also has docs to write and forum posts to update13:26
jdstrandpedronis: oh, and I13:28
jdstrand'm mashing 'Restart' for PR 7124's tests (normal intermittent non-PR related failures)13:28
mupPR #7124: many: create system-usernames user/group if both don't exist <Created by jdstrand> <https://github.com/snapcore/snapd/pull/7124>13:29
jdstrandthe other two have passed13:29
Chipacamvo: https://knowyourmeme.com/memes/naruto-run13:30
mvoChipaca: ta13:31
Chipacamvo: can't have our manager falling that far behind13:32
mupPR snapd#7146 opened: UC20: cmd/snap-verify: sketch of snap-verify <Created by pedronis> <https://github.com/snapcore/snapd/pull/7146>14:08
* cachio AFK14:11
mupPR core-build#47 closed: initramfs: restore wait-for-root calls <Created by cmatsuoka> <Merged by mvo5> <https://github.com/snapcore/core-build/pull/47>14:23
ackkjdstrand, hi, did you by chance manage to reproduce the issue with systemd-detect-virt not working in a VM?14:40
Chipacaackk: in which vm?14:50
Chipacaackk: and not working how?14:50
ackkChipaca, https://bugs.launchpad.net/snapd/+bug/183147314:51
ackk(recent comments)14:51
mupBug #1831473: Can't run /usr/bin/systemd-detect-virt from inside snap <maas> <snapd:New for jdstrand> <https://launchpad.net/bugs/1831473>14:51
Chipacaackk: ah ok14:51
Chipacaackk: for a moment i thought maybe it had something to do with systemd-detect-virt using capabilities instead of setuid14:52
ackkChipaca, it doesn't seems not being able to read /proc/1/sched is really an issue (I did mention it since I was getting a denial there)14:53
Chipacaackk: I blame mvo15:05
ograhe's so easy to blame15:07
cwayneogra: not as easy as ondra though15:15
ogratrue dat ....15:16
mvoChipaca: wuut?15:22
ijohnsoncwayne: don't you mean ondras15:29
cwayneI refuse to believe there's more than one15:29
ograsince people recently start mixing up ogra and ondra all the time in pings i guess he just wants to be more than me now :P15:42
ackkChipaca, so you know what's going wrong, or just generically blaming mvo? :)15:55
Chipacaackk: just generically15:57

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!