/srv/irclogs.ubuntu.com/2021/10/28/#snappy.txt

mborzeckimorning04:53
pstolowskimorning07:05
mborzeckipstolowski: hey07:07
pstolowskimborzecki: need any other reviews?07:19
mborzeckipstolowski: i think i'm good right now07:20
mborzeckipstolowski: anything in your validation sets branches that needs looking at?07:21
pstolowskimborzecki: no, i'm good for now as well, thanks07:22
mupPR snapd#10982 opened: i/b/common_test: refactor AppArmor features test <Simple 😃> <Skip spread> <Created by mardy> <https://github.com/snapcore/snapd/pull/10982>07:22
mborzeckimardy: hi, i've commented in https://github.com/snapcore/snapd/pull/10918#pullrequestreview-790768022 does this answer the questions you had?07:26
mupPR #10918: osutil/disks: add methods to replace gadget/ondisk functions  <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10918>07:26
pstolowskimardy: need reviews in any particular order?08:12
mardypstolowski: this one would help, because then I rebase the sysmodule capability on top of it: https://github.com/snapcore/snapd/pull/1091808:23
mupPR #10918: osutil/disks: add methods to replace gadget/ondisk functions  <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10918>08:23
pstolowskimardy: i approved it yesterday already08:24
mardypstolowski: sorry, wrong link :-) https://github.com/snapcore/snapd/pull/1098208:27
mupPR #10982: i/b/common_test: refactor AppArmor features test <Simple 😃> <Skip spread> <Created by mardy> <https://github.com/snapcore/snapd/pull/10982>08:27
pstolowskiok08:28
mvohey, I'm a bit out-of-touch right now but I do see some 18.04 related lxd failures in some of the recent spread runs, does anyone know more what's up here? is someone looking :) ?08:33
mvo(also 20.04 it seems?)08:33
* mvo has some vague memory this was talked about but can't remember08:34
pstolowskimvo: afair mborzecki said that lxd from candidate (that we reported a bug for) was promoted to stable regardless08:36
pstolowskibut maybe it's something else now?08:36
mvopstolowski: ok, I will see if I can find osmething out from the lxd ppl08:36
mvomborzecki: 10980 looks like it's good to go?08:36
mborzeckimvo: yes, if there are no futher comments then we should land it and the kylen try it08:37
mborzeckimvo: also, https://github.com/snapcore/snapd/pull/10947 can land too08:38
mupPR #10947: tests: run spread tests on debian 11 <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10947>08:38
pstolowskimborzecki: do you know about that lxd issue ^? is this the same you looked at earlier this week08:40
mborzeckipstolowski: the nested one failing? yeah, according to guys in mm it shoudl be fixed in edge now08:41
mupPR snapd#10947 closed: tests: run spread tests on debian 11 <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10947>08:42
mupPR snapd#10980 closed: o/devicestate: copy timesyncd clock timestamp during install <Run nested> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10980>08:42
mupPR snapd#10983 opened: spread: run lxd tests with version from latest/edge <Created by mvo5> <https://github.com/snapcore/snapd/pull/10983>08:47
mupPR snapd#10982 closed: i/b/common_test: refactor AppArmor features test <Simple 😃> <Skip spread> <Created by mardy> <Merged by mardy> <https://github.com/snapcore/snapd/pull/10982>09:27
mardymborzecki: I just added a comment to the same PR, I think that the +1 is correct but I still don't get why we don't subtract StartLBA09:29
mborzeckimardy: yeah, i think there's some confusion about the purpose or the kind of the size information returned there09:34
mborzeckiin certain scenarios (eg. layout) we need to know the actual block device size 09:35
mborzeckiwhile in other cases we only need to know the usable size (eg. expanding ubuntu-data)09:35
pstolowskimardy: sorry, i was going to review 10982 but was in a meeting, and now it landed (with 1 review?)09:36
mardypstolowski: np, I was was a bit surprised that the button was green, but since it affects the tests only I thought it was safe to merge. But of course you can comment if you see something wrong, I will address them in a follow up09:42
mardypstolowski: that at least unblocked me to update https://github.com/snapcore/snapd/pull/10933 (which also needs a re-review, BTW :-) )09:43
mupPR #10933: interfaces: suppress denial of sys_module capability <Created by mardy> <https://github.com/snapcore/snapd/pull/10933>09:43
pstolowskimardy: no worries, i'm a bit surprised you could land it yourself, i didn't know it would work with 1 review09:43
mborzeckipstolowski: simple selinux policy fix https://github.com/snapcore/snapd/pull/1098410:07
mupPR #10984: data/selinux: allow snap-confine to read udev's database <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10984>10:07
mupPR snapd#10984 opened: data/selinux: allow snap-confine to read udev's database <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10984>10:08

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!