[00:07] <mup> PR snapcraft#2568 closed: docs: consolidate on a simple HACKING.md <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2568>
=== jamesh_ is now known as jamesh
[05:06] <mborzecki> morning
[06:00] <zyga> Hey mborzecki
[06:00] <mborzecki> zyga: hey
[06:00] <mborzecki> zyga: how's your day off coming? :)
[06:00] <zyga> Haha
[06:00] <zyga> I was just wondering the same thing
[06:00] <zyga> Should I take today off for real
[06:00] <zyga> Or work some more to get stuff done
[06:01] <zyga> So many things to work on
[06:05] <zyga> mborzecki: I sent a small patch for spread-shellcheck
[06:05] <zyga> And had an idea on how to fix not MATCH
[06:07] <zyga> We can save MATCH to lib/bin on startup
[06:07] <zyga> Like we do now to match.sh include file
[06:07] <zyga> Since it is on path it will be more flexible
[06:08] <zyga> Then MATCH is no longer a function
[06:08] <zyga> Then we can put “not” on path and fix all tests
[06:15] <mborzecki> zyga: in other news, got an image built by snap-image (strawman) to boot up to a point where i got console conf :P
[06:16] <zyga> Wooooot
[06:16] <zyga> That is great
[06:17] <zyga> It still feels that landing your changes will take a month
[06:17] <mborzecki> yeah, and tests and all that
[06:18] <mborzecki> zyga: if you guys have a system-rescue role that you'd like me to add or something, this coudl be done really easily
[06:19] <zyga> Role as in partition type?
[06:19] <zyga> I think we should talk about how the recovery system is designed, so far, to keep you in the loop
[06:19] <mborzecki> zyga: role as role in gadget.yaml terms, and whatever that means practically, eg. like system-boot is a bit special
[06:19] <mborzecki> zyga: and so is system-data
[06:20] <zyga> I think some things there will change
[06:20] <zyga> Though I think that is best for next week
[06:37] <zyga> re, back in the office
[06:38] <zyga> mborzecki: can you do a quick review of https://github.com/snapcore/snapd/pull/6906
[06:38] <zyga> just a variable rename
[06:38] <mup> PR #6906: cmd/snap-update-ns: rename ctx to upCtx <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6906>
[06:38] <zyga> though more importantly I need a review for https://github.com/snapcore/snapd/pull/6903 to get 2.39.1 fix in place
[06:38] <mup> PR #6903: spread-shellcheck: add support for variants and environment <Created by zyga> <https://github.com/snapcore/snapd/pull/6903>
[06:38] <zyga> the shellcheck change is not perfect
[06:38] <zyga> but it's also not totally incorrect
[06:38] <zyga> and allows my tests to not get stuck on that
[07:01]  * zyga quick coffee
[07:01] <zyga> mborzecki: if you can review the spread-shellcheck change I will be able to propose the propagation fixes
[07:03] <zyga> I will do some branch gardening soon
[07:03] <zyga> but first coffee
[07:04] <pstolowski|afk> morning
=== pstolowski|afk is now known as pstolowski
[07:09] <zyga> Hey :-)
[07:19] <zyga> Interesting https://forum.snapcraft.io/t/snapshots-can-expose-sensitive-data/11493
[07:27] <pstolowski> zyga: hmm interesting indeed
[07:27] <mup> PR snapd#6906 closed: cmd/snap-update-ns: rename ctx to upCtx <Simple 😃> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6906>
[07:27] <zyga> makes me feel that snapshots should be saved back to $HOME
[07:27] <zyga> as anything else is not correct wrt NFS and encryption
[07:28] <zyga> pstolowski: quick trivial https://github.com/snapcore/snapd/pull/6907
[07:28] <mup> PR #6907: cmd/snap-update-ns: add several TODO comments <Created by zyga> <https://github.com/snapcore/snapd/pull/6907>
[07:28] <zyga> just comments
[07:28] <zyga> but that's *all* of the refactoring :D
[07:28] <zyga> wooooot
[07:28] <mup> PR snapd#6907 opened: cmd/snap-update-ns: add several TODO comments <Created by zyga> <https://github.com/snapcore/snapd/pull/6907>
[07:29] <pstolowski> +1§
[07:30] <mborzecki> pstolowski: hey
[07:30] <pstolowski> o/
[07:40] <mup> PR snapd#6894 closed: tests: add "not" command as replacement for "!" in tests <Created by zyga> <Closed by zyga> <https://github.com/snapcore/snapd/pull/6894>
[07:44] <mup> PR snapd#6908 opened: tests: add "not" command <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6908>
[08:05] <zyga> mborzecki, pstolowski: how do you feel about ^ not
[08:05] <zyga> I want to build this on top  https://github.com/snapcore/snapd/pull/6909
[08:05] <mup> PR #6909: spread.yaml,tests: change MATCH and REBOOT to cmds <Created by zyga> <https://github.com/snapcore/snapd/pull/6909>
[08:05] <zyga> and then fix our scripts to use not rather than !
[08:06] <mup> PR snapd#6909 opened: spread.yaml,tests: change MATCH and REBOOT to cmds <Created by zyga> <https://github.com/snapcore/snapd/pull/6909>
[08:11] <pstolowski> zyga: interesting; don't we still need to make it a compound expressionm e.g. { ! "$@" } ?
[08:11] <zyga> no,  why?
[08:12] <zyga> ! functions correctly
[08:12] <zyga> note that this executable is not sourced, it's a program that runs without set -e
[08:12] <pstolowski> zyga: ok, so -e is the key here. i was reading also https://stackoverflow.com/questions/39581150/why-do-i-need-parenthesis-in-bash-set-e-and-negated-return-code/39582012
=== icey_ is now known as icey
[08:22] <zyga> I wonder if snapd is going to get any sponsors: https://techcrunch.com/2019/05/23/github-launches-sponsors-lets-you-pay-your-favorite-open-source-contributors/
[08:40] <zyga> mborzecki: https://github.com/google/pytype
[08:40] <zyga> mborzecki: from that video you linkedto
[08:51] <zyga> mborzecki: updated https://github.com/snapcore/snapd/pull/6903
[08:51] <mup> PR #6903: spread-shellcheck: add support for variants and environment <Created by zyga> <https://github.com/snapcore/snapd/pull/6903>
[08:55] <mborzecki> zyga: nhm, lgtm
[08:56] <zyga> nhm?
[09:00] <zyga> mborzecki: something for you :) https://github.com/snapcore/snapd/pull/6910
[09:00] <mup> PR #6910: spread.yaml: use "snap connections" in debug <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6910>
[09:00] <mup> PR snapd#6910 opened: spread.yaml: use "snap connections" in debug <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6910>
[09:03]  * zyga really gets that coffee now
[09:03] <zyga> after the break I will try to land "not" and "MATCH" as commands and see if I can fix ! tree-wide
[09:03] <zyga> and revert shellcheck patch so that we track edge again
[09:17] <zyga> back now :)
[09:17] <zyga> aaaand, "not" is red
[09:20] <mup> PR snapd#6907 closed: cmd/snap-update-ns: add several TODO comments <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6907>
[09:35] <pstolowski> and i just had google:ubuntu-14.04-64:tests/main/parallel-install-aliases failure on one of my PRs
[09:35] <pstolowski> never seen it failing
[09:38] <zyga> pstolowski: how did it fail?
[09:40] <pstolowski> zyga: it was expecting the change to fail with 'cannot enable alias "alias1" for "aliases_foo", already enabled for "aliases"', but instead got 'Done    today at 15:27 UTC  today at 15:27 UTC  Setup manual alias "alias1" => "cmd1" for snap "aliases"'
[09:40] <pstolowski> zyga: i wonder it snap change --last=alias check there isn't racy
[09:41] <zyga> huh, I saw that fail once as well
[09:41] <zyga> yesterday
[09:41] <pstolowski> because just above we test happy execution
[09:41] <pstolowski> zyga: i'll kick it again on travis and in the meantime execute and investigate it locally
[09:41] <zyga> k
[09:42] <pstolowski> and if that's it, will fix it
[09:42] <zyga> pstolowski: can you look at https://github.com/snapcore/snapd/pull/6903
[09:42] <mup> PR #6903: spread-shellcheck: add support for variants and environment <Created by zyga> <https://github.com/snapcore/snapd/pull/6903>
[09:42] <pstolowski> k
[09:42] <zyga> I need a 2nd review to open the fix for the mount propagation PR
[09:52] <zyga> mborzecki: curious, permissions package seems to be updated with some snapd bits
[09:52] <zyga> as a simple build in obs failed on that
[09:52]  * zyga looks
[09:53] <zyga> settle not converging
[09:53]  * zyga loves when unit tests fail
[09:54] <zyga> pstolowski: does this sound familiar?
[09:54] <zyga> https://www.irccloud.com/pastebin/02IEvvjO/
[09:55] <zyga> ah, this is device registration, not hotplug
[09:55] <zyga> sorry
[09:55] <zyga> bah
[09:56] <zyga> this happens each time
[09:56]  * zyga debugs
[10:01] <mup> PR snapd#6893 closed: gadget: helper for shifting structure start position <Gadget update> <Simple 😃> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/6893>
[10:01] <zyga> hrm
[10:01] <zyga> go test passes on my tree with 2.39
[10:01] <zyga> fails in the tarball
[10:01] <zyga> whhyyyyy
[10:05] <zyga> hmmm
[10:14] <zyga> I disabled unit tests and installed the resulting package
[10:14] <zyga> let's see how it operates
[10:14] <zyga> then I can see why they fail again
[10:20] <zyga> eh
[10:20] <zyga> in x11 mode I don't have /snap/bin on path
[10:20] <zyga> in wayland mode some apps just crash
[10:20] <zyga> lovely
[10:23] <zyga> after reboot things seem to be have
[10:23] <zyga> behave even
[10:35] <pstolowski> zyga: hmm somewhat, seen failures like this from time to time while working on these tests, usually was a race. you're saying it fails each time like this?
[10:35] <zyga> do you remember https://github.com/snapcore/snapd/pull/6360 <- I just merged master into it :)
[10:35] <mup> PR #6360: cmd/snap-update-ns: refactor of profile application <Per-user mount ns  🐎> <Created by zyga> <https://github.com/snapcore/snapd/pull/6360>
[10:35] <zyga> pstolowski: yeah
[10:35] <zyga> but only in packaging build
[10:35] <zyga> not in a checkout
[10:35] <zyga> I didn't look deeper yet
[10:36] <zyga> "not" failed again
[10:37] <pstolowski> zyga: on which test?
[10:37] <zyga> service watchdog
[10:51] <pstolowski> zyga: +1 on 6903 with a question
[10:51] <zyga> looking
[10:55] <pstolowski> of course parallel-install-aliases is passing when run locally... will keep it running during lunch
[10:56] <zyga> pstolowski: replied there
[11:00] <pstolowski> ty
[11:00]  * pstolowski lunch
[11:03] <mup> PR snapd#6903 closed: spread-shellcheck: add support for variants and environment <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6903>
[11:04] <zyga> I've opened https://github.com/snapcore/snapd/pull/6891 for real now
[11:04] <mup> PR #6891: many: make per-snap mount namespace MS_SHARED <Created by zyga> <https://github.com/snapcore/snapd/pull/6891>
[11:04] <zyga> tests *should* pass now
[11:04] <zyga> so fingers crossed
[11:05] <zyga> I think I need a break
[11:05] <zyga> but it's moving along
[11:05] <zyga> what do you guys think about https://github.com/snapcore/snapd/pull/6909 ?
[11:05] <mup> PR #6909: spread.yaml,tests: change MATCH and REBOOT to cmds <Created by zyga> <https://github.com/snapcore/snapd/pull/6909>
[11:05] <zyga> I will work on mountinfo-tool to support earlier versions of python so that we can use it in 16.04
[11:09] <mup> PR snapd#6911 opened: cmd/snap-update-ns: rename leftover ctx to upCtx <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6911>
[11:11]  * zyga breaks
[11:14] <mup> PR snapd#6912 opened: gadget: keep track of the index where structure content was defined <Gadget update> <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6912>
[11:15] <mup> PR snapd#6883 closed: tests: fix how strings are matched on auto-refresh-retry test <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6883>
[11:15] <mup> PR snapd#6910 closed: spread.yaml: use "snap connections" in debug <Simple 😃> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6910>
[11:17] <zyga> mborzecki: is https://github.com/snapcore/snapd/pull/6890 really for review?
[11:17] <mup> PR #6890: gadget: mounted filesystem writer & updater <Gadget update> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6890>
[11:17] <mborzecki> zyga: heh, yes
[11:17] <zyga> *gulp*
[11:17] <mborzecki> zyga: want to dive in? :)
[11:18] <zyga> they told me to split a 1K diff
[11:18] <zyga> took several moths to review
[11:18] <zyga> *months
[11:18] <zyga> (i'd be faster with moths :D
[11:18] <mborzecki> zyga: 1.6k is tests :P
[11:18] <zyga> for me 80% was tests
[11:18] <zyga> good luck :-)
[11:18] <zyga> no way to chunk that?
[11:19] <mborzecki> idk, maybe i could sample, method by method :/
[11:19] <zyga> at the end of the day I can review and approve but you need extra reviews from samuele
[11:19] <mborzecki> hm maybe i could pull the writer thing apart, that's ~10% of the thing
[11:20] <zyga> ok, really time to break now
[11:20] <zyga> I'll merge "not" when green
[11:20] <zyga> and if you guys can review https://github.com/snapcore/snapd/pull/6909 we could fix all of ! foo bugs
[11:20] <mup> PR #6909: spread.yaml,tests: change MATCH and REBOOT to cmds <Created by zyga> <https://github.com/snapcore/snapd/pull/6909>
[11:20] <mup> PR snapd#6913 opened: tests: force snap-reexec test to fail to reproduce the error on ubuntu 14.04 <⛔ Blocked> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6913>
[11:29] <mborzecki> zyga: should we have NOT instead of lowercase not to match MATCH and REBOOT?
[11:36] <popey_> chipaca not working today?
[11:46] <zyga> mborzecki: MATCH and REBOOT come from spread
[11:46] <zyga> popey_: I think he's off today
[11:46] <zyga> mborzecki: I think lowercase "not" looks nicer
[11:46] <popey_> ta
[11:47] <zyga> mborzecki: but to answer your question, I kept REBOOT and MATCH uppercase only to match spread names and avoid code changes
[11:47] <zyga> not failed again :D
[11:47] <zyga> heh
[11:47] <zyga> landing a trivial unused file
[11:47] <mborzecki> pstolowski: a look at https://github.com/snapcore/snapd/pull/6912 ?
[11:47] <mup> PR #6912: gadget: keep track of the index where structure content was defined <Gadget update> <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6912>
[11:48] <zyga> this time on refresh-delta-from-core
[11:48] <zyga> meh
[11:48] <zyga> I'll grab some food
[11:48] <zyga> ttyl
=== ricab is now known as ricab|lunch
=== alan_g is now known as alan_g|lunch