[05:26] <mborzecki> morning
[05:57] <jamesh> mborzecki: are you able to restart the failed sub-job in https://travis-ci.org/snapcore/snapd/builds/562037700 ?
[06:01] <mborzecki> jamesh: sure, let me check
[06:01] <jamesh> thank you
[06:02] <mborzecki> jamesh: ok, restarted
[06:22] <zyga> Hello
[06:34] <mborzecki> zyga: hey
[06:45] <zyga> I will be around in 30
[06:55] <mborzecki> need to run a quick errand
[06:55] <mborzecki> mvo: morning
[06:55] <mborzecki> zyga: mvo: i'm updating the notes on cgroups https://gist.github.com/bboozzoo/76b1535c93686a27bb7fdbaad0f560f7 and testing some things along the way
[06:55] <mborzecki> back in 30 or so
[07:02] <mvo> hey mborzecki
[07:02] <mvo> mborzecki: nice, thank you!
[07:11] <zyga> back now
[07:11] <zyga> mborzecki: looking
[07:12] <zyga> mvo: some good progress last week, apart from me forgetting to modify data sets for ubuntu core the new mount ns test is good
[07:13] <mup> PR snapd#7139 closed: tests: don't leak /run/netns mount <Simple 😃> <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7139>
[07:13] <zyga> mborzecki: I have answers to some of the TODOs there
[07:18] <mup> PR snapd#7127 closed: tests: removing support for ubuntu cosmic on spread test suite <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7127>
=== JanC_ is now known as JanC
[07:24]  * zyga breakfast
[07:53] <zyga> mborzecki: do you think my explanation on https://github.com/snapcore/snapd/pull/7138 makes sense?
[07:53] <mup> PR #7138: tests: remove lxd / lxcfs if pre-installed <Created by zyga> <https://github.com/snapcore/snapd/pull/7138>
[08:03] <mborzecki> re
[08:28] <mup> PR snapd#7138 closed: tests: remove lxd / lxcfs if pre-installed <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7138>
[08:29] <mvo> mup is back!
[08:29] <mvo> woooooh!
[08:33] <Chipaca> pedronis: WDYT of returning an ad-hoc struct from GetCurrentBlah?
[08:34] <pedronis> Chipaca: it's fine,  adding Revision to PlaceInfo wouldn't be a bad idea
[08:34] <pedronis> but is a chunk of work because Info.Revision exists
[08:35] <Chipaca> pedronis: yeah, i'd need to hunt down all those first, but it's easy to do :-)
[08:35] <Chipaca> pedronis: should I park this, do the revision thing, and then do this?
[08:35] <Chipaca> i could timebox it to ~1h
[08:37] <jamesh> zyga: did you have any more comments on https://github.com/snapcore/snapd/pull/6959 (adding osutil.EnsureTreeState) after the last round of changes?
[08:37] <mup> PR #6959: osutil: add EnsureTreeState helper <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/6959>
[08:37] <pedronis> Chipaca: let's start with a simple struct
[08:37] <pedronis> and consider the other issue separately
[08:38] <mup> PR snapd#7141 closed: tests: add mountinfo-tool --ref-x1000 <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7141>
[08:38] <zyga> jamesh: I'll review it now
[08:38] <jamesh> zyga: thanks!
[08:38] <Chipaca> pedronis: ack
[08:39] <jamesh> zyga: I think everything is ready to land for https://github.com/snapcore/snapd/pull/7054 too
[08:39] <mup> PR #7054: interfaces: add an interface that grants access to the PackageKit service <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/7054>
[08:39] <zyga> jamesh: I'll check it out as well
[08:39] <zyga> ah, I remember it :)
[08:47] <Chipaca> pedronis: a single struct with kernel and core names and revisions, or two structs each with just naem and revision?
[08:47]  * Chipaca is full of silly questions today
[08:47] <Chipaca> pedronis: i think two structs works better in this case
[08:47] <Chipaca> pedronis: but I don't know how you expect this to grow, yet
[08:49] <ackk> hi, is there a way to strace a program manually run inside a "snap run --shell" session ?
[08:50] <pedronis> Chipaca: sorry, I still think this should take snap.Type
[08:50] <Chipaca> :-(
[08:50] <pedronis> (it's the thing we need anyway going forward)
[08:50] <Chipaca> so much work done n times
[08:50] <Chipaca> but, ok
[08:51] <Chipaca> also it becomes a bunch of ifs again which is ugly
[08:51] <Chipaca> augh
[08:51] <pedronis> Chipaca: ?
[08:52] <Chipaca> pedronis: if type is kernel look for snap_kernel if type is core or base or os look for snap_core
[08:52] <pedronis> Chipaca: you understand that the one in booted goes way
[08:52] <pedronis> then, though
[08:52] <pedronis> that one has an if/switch anyway
[08:52] <Chipaca> ah, good point
[08:53] <pedronis> sorry, I thought this through but wasn't explicit
[08:53] <Chipaca> pedronis: booted has two calls to this though, and one of them will be calling this twice
[08:53] <pedronis> yes
[08:53] <pedronis> I know
[08:53] <Chipaca> ok
[08:53] <pedronis> that was my comment about efficient
[08:53] <Chipaca> on it
[08:53] <Chipaca> yeah, i figured
[08:53] <pedronis> but we'll need to change that anyway
[08:53] <pedronis> because at some point base and kernel info will be in two different places
[08:53] <pedronis> so something has to give
[09:04] <Chipaca> pedronis: a problem(ish, maybe more so in the future) with making it take type is that UpdateBootRevisions would, on the surface, need to know whether to use base or core
[09:04] <Chipaca> right now it makes no difference and I'll just use TypeOS
[09:05] <Chipaca> but core20 might make that harder
[09:05] <pedronis> Chipaca: I expect all this code to change again
[09:06] <Chipaca> "Ave, Haxor, morituri te salutant"
[09:06] <pedronis> Chipaca: I would use TypeBase thoug, no?  and have a comment where used
[09:06] <Chipaca> pedronis: the result is the same either way -- why Base and not OS?
[09:07] <pedronis> Chipaca: because OS is "legacy" (dreaded word)
[09:07] <Chipaca> :-)
[09:07]  * Chipaca does «legacy, err := boot.GetCurrentBoot(snap.TypeOS)»
[09:07] <Chipaca> pedronis: base it is then
[09:11] <Chipaca> pedronis: type NameAndRevno, or type NameAndRevision?
[09:11] <mup> PR snapd#7140 closed: overlord/devicestate: update gadget update handlers and mocks <Gadget update> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7140>
[09:15] <popey_> jwheare: is 0.13.0 based off an internal branch?
[09:15] <jwheare> it's master
[09:15] <jwheare> hence edge channel
[09:16] <popey_> ahh okay
[09:16] <popey_> we'll start the machinery to create a pr for irccloud-desktop to put a face-punching dialog in it later
[09:16] <popey_> in preparation
[09:17] <tomwardill> yay, irccloud and snaps <3
[09:19]  * tomwardill switched
=== alan_g_ is now known as alan_g
[09:38] <pedronis> Chipaca: NameAndRevision
[09:40] <Chipaca> hmm, i've had to add boot vars to one of the manager tests for it to pass
[09:40] <Chipaca> something's leaking :-|
[09:40] <Chipaca> should probably add ad-hoc methods to MockBootloader to set these things instead of raw boot vars
[09:45] <pedronis> Chipaca: mmh, probably slightly better to have a function that takes a MockBootloader instead of a method
[09:45] <pedronis> we might have many mock bootloaders laters
[09:45] <pedronis> maybe
[09:45] <pedronis> or something else
[09:46] <pedronis> Chipaca: boottest.SetBoot(bootloader,...) or something
[09:47] <Chipaca> pedronis: boottest.SetBootKernel(kernel, bootloader...)?
[09:48] <Chipaca> wth why does seahorse suddenly refuse to see my gpg keys
[09:48] <Chipaca> i'm going to have to edit the expiration on the terminal, like a caveman
[09:48] <pedronis> Chipaca: that works though, and SetBootBase ?
[09:48] <pedronis> doesn't need to take many for now
[09:48] <pedronis> I mean many bootloaders
[09:49] <Chipaca> pedronis: and SetBootMode maybe
[09:49] <Chipaca> i'll look to see how much that one is set outside of boot itself
[09:49] <Chipaca> first need to sort out my gpg keys as they've _just_ expired :)
[09:50] <mup> PR snapd#7054 closed: interfaces: add an interface that grants access to the PackageKit service <Created by jhenstridge> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7054>
[09:59] <jwheare> popey_: 0.13.0 has now been released, but the snap will continue to be edge channel due to the config perms crash